Option to disable "staging whole file via mouse click"

[maliayas]

Is your feature request related to a problem? Please describe.

When navigating the uncommited Files box, sometimes I may click on a file name which already was highlighted. Or think about a double-click by mistake instead of single-click. These actions stage the whole file. This is usually unintended operation for me. If the file was partially staged at the moment, that is now gone.

Describe the solution you'd like

So if there was a config option to turn this functionality off, it would be super great. This way, staging would consistently always depend on pressing Space on keyboard.

[ChrisMcD1]

Do you want disable all click actions, or just the click action that stages files?

[maliayas]

Just the click action that stages/unstages files. Otherwise doing things via click is pretty useful.

[stefanhaller]

I wouldn't want to add a config option for this, as I find double-clicking to be useful and it doesn't strike me as something you'd do accidentally.

The real problem here is that we don't do proper double-click detection; we treat any click on an already selected item as a double-click, no matter how much time has passed between the clicks. This is something that we should fix.

[maliayas]

I can agree with that. Destructive actions can be bound to (real) double click. Single click is more like to select an item (if we are in a list of items).

As you noted, the current problem here is false detection of double click.