Lazygit crashes with tea.xyz on the system

[owittek]

Describe the bug
lazygit crashes on startup. I honestly no idea why this issue happens since I installed lazygit via brew but installing it with tea results in the same issue.

The more confusing part is that it even worked in the beginning and suddenly started crashing. This might also be a bug in the most recent version of tea.

To Reproduce
Steps to reproduce the behavior:

1. Install tea.xyz
2. Run lazygit

Expected behavior
I'm expecting lazygit to properly open

Version info:
commit=, build date=, build source=unknown, version=0.38.2, os=darwin, arch=arm64, git version=2.41.0

Additional context

2023/06/07 14:07:32 An error occurred! Please create an issue at: https://github.com/jesseduffield/lazygit/issues

*strconv.NumError strconv.ParseBool: parsing "tea: installing git-scm.org\nfalse": invalid syntax
github.com/jesseduffield/lazygit/pkg/app/app.go:54 (0x10077ac50)
github.com/jesseduffield/lazygit/pkg/app/entry_point.go:146 (0x10077c66c)
github.com/jesseduffield/lazygit/main.go:23 (0x10077e208)
runtime/internal/atomic/types.go:194 (0x100195ee8)
runtime/asm_arm64.s:1172 (0x1001c6134

CC @mxcl

[mark2185]

Could you please post your config.yml and try launching lazygit without it?

Also, does it happen in all folders or just in some?

[owittek]

I don't have a config.yml and it seems to happen in every folder

[mark2185]

parsing "tea: installing git-scm.org\nfalse"

Well this is being parsed from somewhere.

This might also be a bug in the most recent version of tea.

Could you somehow try disabling tea to possibly rule it out as the cause?

[owittek]

Yep, disabling tea by not sourcing it in my .zshrc fixes the issue.

[mxcl]

*strconv.NumError strconv.ParseBool: parsing "tea: installing git-scm.org\nfalse": invalid syntax

tea is being used to install git somehow. We print these messages to stderr which typically is not parsed for data, all the same it would be good to find out what git command line is being called so we can determine if printing nothing is really the right thing to do.

It's odd that tea is being called to install git, I can only conclude that there's a symlink from git to tea somewhere? Since our install magic cannot be invoked by lazygit any other way I can think of.

[mxcl]

So we feel this is our bug in that we shouldn't break other tools, however, lazygit should probably not be parsing stderr here. Even if we fix this in the event of git adding spurious stderr this would also break. We'll let you know when we have a solution.

Sorry for the issue!

Also: we'll pkg up lazygit: looks cool!

[owittek]

*strconv.NumError strconv.ParseBool: parsing "tea: installing git-scm.org\nfalse": invalid syntax

tea is being used to install git somehow. We print these messages to stderr which typically is not parsed for data, all the same it would be good to find out what git command line is being called so we can determine if printing nothing is really the right thing to do.

It's odd that tea is being called to install git, I can only conclude that there's a symlink from git to tea somewhere? Since our install magic cannot be invoked by lazygit any other way I can think of.

I think that's a bug now that tea automatically symlinks. If I have the tea one-liner in my .zshrc my shell uses .tea/.local/bin/git. It also tries to install golang and llvm for some reason, although both of them are installed.

[mxcl]

I think that's a bug now that tea automatically symlinks

well it only adds that if git is already installed, so something’s amiss if it is trying to install things that are already installed. Let’s continue this discussion at pkgxdev/pkgx#604 since it seems similar.

[ChrisMcD1]

@owittek Is this fixed by the commits mentioned above in tea?

[mxcl]

I would expect this to be fixed. We had a number of similar issues with tools that combine both stdout and stderr (even though they probably don’t want stderr) so fixed it by not outputting any progress information if stderr is not a tty, which is probably correct anyway.