Remapped 'confirm' hotkey doesn't go well with the search prompt

[vlad-psh]

Describe the bug

I thought remapping confirm action to the y key would be very nice, but it seems like search prompt is also using this hotkey rather than separate configuration 🥲

keybinding:
  universal:
    confirm: 'y' # default: '<enter>'

lazygit/pkg/gui/controllers/search_prompt_controller.go

Lines 26 to 30 in 585ea36

	{
	Key: opts.GetKey(opts.Config.Universal.Confirm),
	Modifier: gocui.ModNone,
	Handler: self.confirm,
	},

I wonder will it be better to just use fixed <enter> hotkey for search prompts? I guess it makes more sense to be fixed, so even if we remap confirm to any non-alphanumeric hotkey (eg <c-j>), our search prompt will not insert newlines on <enter>, producing a little bit confusing result.

What do you guys think?

PS: Oh, seems like this behavior is also can be seen in all the modal windows (like name prompt when creating new branch, etc). So basically it's a bad idea to remap this 😔 If only there was an confirm-alt remap option like for some other actions...

Version info:

lazygit 0.38.2

[xaviergmail]

I've changed my keybinding to 'y' as well after experiencing #2611, #3300, #3471, #2009 - and now I can't create a branch- there's no way for me to "confirm" after the branch name

[stefanhaller]

I opened #4860 to fix this, please test.