Reset doesn't work

[emmet-clarke]

Let's say I accidentally commit to local master. I navigate to the commits pane, highlight the commit in question, press g and I get a window asking me if I want a mixed, soft, or hard reset. With the indicated keys of m, s, or h. None of these keys do anything nor does highlighting one of them and pressing enter.

[mark2185]

Does running the same thing in the terminal yield any (different) results?

Also would you kindly fill out the issue template?

[emmet-clarke]

Yes running git reset --hard HEAD~1 works fine.

[emmet-clarke]

Describe the bug
Pressing g to reset a commit doesn't work.

To Reproduce
Steps to reproduce the behavior:

See previous post

Expected behavior
I expected a hard reset after pressing h or failing that, pressing enter on the option.

Screenshots
see previous post

Version info:
commit=9f03f9e95, build date=20241118.192217, build source=unknown, version=v0.44.1.9f03f9e95, os=linux, arch=amd64, git version=2.48.0

Additional context
Thank you kindly

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

[mark2185]

And just to confirm, 17da90 is the HEAD~1 commit? You're not selecting the HEAD commit and pressing g on it?

I don't recall any PRs related to that, but you could try updating to v0.46.0.

[ChrisMcD1]

Just rebuilt 0.44.1 and I'm unable to reproduce this error. Can you try creating a fresh repository, and adding some dummy commits?

Like so:

mkdir test-reset
cd test-reset
git init
git commit --allow-empty -m "First commit"
git commit --allow-empty -m "Second commit"

and then try launching lazygit -debug and doing gh while hovering over the first commit.

After this run lazygit -logs and send us those! Might show something useful.

[Master727]

I'm running into the same issue. I commit some files and nothing happens when I run reset, mixed or soft. After looking at the commands log lazygit is running git reset --mixed 6eac474e0c5ef60c1bbcb9dfa829767f0b29dabd. When I try to run it from the command line same results. Nothing happens. I'm running version 0.48.0

However, I did get it to work with git rest --mixed HEAD~1 Not too sure why it doesn't work with the commit sha though

[stefanhaller]

That's expected behavior. You need to pass the commit that you want to reset to, not the one that you want to get rid of. It works like this both on the command line and in lazygit.

[Master727]

You're right 😅 I just tried that and it works. Looks like what I should have done is select the commit right before the one I want to undo

[stefanhaller]

Yes, that's precisely what I was endeavouring to convey. 😄