ux: annotation of tag

[laciferin2024]

Describe the bug

• Press <a-enter> to commit should be to ...tag

Follow up question: what is <a-enter> ?

Its not working for me? I have tried every modifier key + enter so far

[stefanhaller]

Making the text in the view frame depend on whether you commit or tag would be quite a bit of work; I wonder if we should simply change it to Press <a-enter> to confirm so that it fits both situations.

As for the other question, does this help?

[laciferin2024]

Confirm: should do it

Regarding the keybindings:

@stefanhaller I have tried multiple terminal emulators. Can we have modifier+enter or a confirm button at bottom right?

[laciferin2024]

I think lazygit should work out of the box at the very least.

[hasecilu]

<a-enter> means Alt + Enter, it's been always working.

[stefanhaller]

it's been always working.

Unfortunately that's not true, or rather, it depends on which terminal emulator you are using. Here's a little table of the ones I tested on Mac:

kitty: ✅
Ghostty: ✅
VS Code's integrated terminal: ✅
iTerm2: 🚫 generates normal enter (can be made to work with custom config, see #4326)
alacritty: 🚫 generates normal enter
Terminal.app: 🚫 generates normal enter
WezTerm: 🚫 (maximizes the window instead)

I haven't investigated whether there are workarounds for the last three.

I think lazygit should work out of the box at the very least.

I would agree with this, but unfortunately we are at the mercy of the terminal emulator here.

A confirm button at the right doesn't strike me as a good solution; I find it much easier to press tab enter as a workaround, instead of reaching for the mouse to click a button.

[laciferin2024]

tab-enter works , but <a-enter>not working is a critical issue for mac os users. At the very least, devs should be able customize and leverage cmd, ctrl keys of the keyboard

[stefanhaller]

tab-enter works , but <a-enter>not working is a critical issue for mac os users.

Why is it so critical? <a-enter> is two keystrokes, and tab enter is also two keystrokes. It even requires less coordination, because you don't have to hold the first key until after you have pressed the second. In fact, I often use tab enter because I do find it easier to type, even though <a-enter> works in my terminal emulator.

At the very least, devs should be able customize and leverage cmd, ctrl keys of the keyboard

See #4397 (comment).

[laciferin2024]

In my case:

Take any application : let it be chatgpt , or the comment i m gonna finalize . Its going to be enter , or ctrl+enter. Its never tab + enter. For windows, I have specifically mapped ctrl+enter -> alt+enter for the same reason.

My brain is wired to prioritize this way over ever since win 7, cuz tab + enter in gui applications usually points to close button (or something else) in a dialog box.

[laciferin2024]

Take this case for instance : tab + enter doesn't work either , it takes 3 tabs to get to comment, this is slower while multitasking.

But ctrl+enter just works!! At times my cursor is close to comment button: even then i m use ctrl+enter. My point being that its not really bout 2 keystrokes , its about adhering to convention.