Move to next file when staging with <space>

[scurvyharbor]

Is your feature request related to a problem? Please describe.
After making changes on a project I mostly stage my files one by one and during that process I check my changes on each file. When doing that it would make sense when staging a file using <space> to jump to the next file (if any) in the tab.

Describe the solution you'd like
Jump to the next file after staging a file using <space>

Additional context
If this would seem a good idea to you guys, I would like to give a go to take this as a first issue

[stefanhaller]

It's an interesting suggestion, and I guess I wouldn't be opposed. I wonder what kind of edge cases we'd have to consider; any situations where you wouldn't want this? What if you unstage a file? What if you press space on a folder? Etc. It might make sense to hack a rough prototype first to see how it feels, before creating a polished PR.

Also, given our past experience with behavior changes and how people complain about them, I'd say we probably should put this behind a config, and it should probably be off by default. Not totally sure about that yet, though.

@jesseduffield Any opinions?

[jesseduffield]

Definitely should not be default behaviour. Often you want to unstage a file to then enter it and stage specific parts.

I actually wonder if it should even be added behind a config at all: if you want to spare key pressed you can use a range select

[stefanhaller]

Often you want to unstage a file to then enter it and stage specific parts.

Yes, that's why I brought up unstaging as a question; I agree we probably shouldn't move the selection in that case.

Using a range selection is not a substitute though. The suggested workflow is that you look at each file's diff to decide whether you want to stage it, and then either press space to stage it or down-arrow to move to the next one. I see how it can be convenient to only have to press one or the other, instead of both space and down-arrow in the first case.

That said, there are also cases where I want to stage almost the entire file, except for one hunk. In that case I will press space to stage everything first, and then enter the file and unstage the hunk I don't want. That's sometimes faster than entering the file and staging all the hunks I want, skipping the one I don't. So this scenario makes the suggested behavior more questionable for me.

@scurvyharbor As a workaround you might try filtering by only unstaged files (press ctrl-b u), this should give you pretty much the behavior you are after, I think.

[scurvyharbor]

My use-case is indeed staging of a complete file only, as this is what I do for 99% of the cases.
Unstaging and other actions are definitely out of scope.
During staging/unstaging everybody has their own way handling this and specific cases require different actions, which might make this behaviour less wanted indeed.
The filtering seems to do the trick for my way of working.
Thanks for your feedback and insights!