k key not work

[zen0bit]

Describe the bug

In Merge conflicts 'k' key for Keep file doesn't work
If I press it move selection to 'd Delete file' even if I move to k Keep file first

Expected behavior

press 'k' should work and apply keep file, same as 'd' do for delete

Screenshots

Version info:

commit=, build date=, build source=voidlinux, version=0.55.1, os=linux, arch=amd64, git version=2.51.0

[stefanhaller]

This is because 'j' and 'k' are bound to move the selection down and up, respectively. It's the same in all list views. And this takes precedence over a menu item's key binding.

I'm a little hesitant to change this to be honest, because I'm unsure if there are any vim users who are actually using these for moving the selection.

Maybe we should solve it by assigning a different binding to the "Keep file" item; like 'p'.

[zen0bit]

This is because 'j' and 'k' are bound to move the selection down and up, respectively. It's the same in all list views. And this takes precedence over a menu item's key binding.

I'm a little hesitant to change this to be honest, because I'm unsure if there are any vim users who are actually using these for moving the selection.

I thought that

Maybe we should solve it by assigning a different binding to the "Keep file" item; like 'p'.

It doesn't really matter to me which will be used, if it just work 😉
PS: not sure which ones are still available to use...

[zingazzi]

#4934

I've change Keep file from K to P.

[stefanhaller]

Addressed by #4934.