Password not prompting

[ndowens]

Maybe I am missing something, but I use ssh key for Github, whenever I select to push in lazygit, it does not prompt for my password, so it never pushes

[mjarkk]

Witch password?,
If it's anything other than git credentials there won't be a popup on screen and if you are on windows we don't support anything more on that later this post.

I've tried to fix this issue sort off earlier but this is a giant pain in the ass if i may call it that :)

Why is this such a shitty thing to fix?
I'm still supper confused about how this all works but from what i know in the base most OSes have a credential manager that handles if a end user can read there GPG / SSH keys ("and decrypts them" in big quotes).

Every shell when opened magically tells the credentials manager where the terminal tty file is (i have no idea how and where this happens) but once this is set and the credential manager needs a password from the user it will direct write that question to the tty file and read it from there (this is not the program and thus makes it impossible to find them).

Usually this is where the help of a PTY comes in (a PTY is a fake shell whereoff we can control) this is also how we currently use to check for git credentials BUT.... the library we use for that makes lazygit much bigger in size and does not work on windows because there PTY solution is made the special windows way and thus close to no library has support for it.
This is why we are not able to read any credentials on windows.

Because of the frustrating windows issue we can't really use a PTY if we want to check for credentials so we started looking at other solutions and this is where the big rabbit hole started.
So git has a solution for this using shell variables that can be set and if set git will ask the program set in the shell var the credential.
Works amazing with one small issues..
Git on windows comes default with a credential manger that asks the credentials in a nice gui that can't be disabled by lazygit, nothing wrong with that except it will ask the credentials in the shell if there are filled in wrong and voila lazygit hangs and cmd is broken NICE.
Well we can sort off live with that, something is always better that nothing.
But now the following, because we don't run lazygit in a pty anymore gpg will start asking again for credentials (ya some ssh and gpg credential manager don't ask if there are ran in a pty???).
But this means we have to find something for that because it suck if a user just presses a button and there shell breaks especially on linux or darwin (windows has to many problems).
And here started the problem of the credential managers and also where my knowledge stops a bit but most OSes have different credential mangers especially for GPG.
All of these work differently (even on different OSes) and have different ways to tell them to ask the credentials in another file and to find all of these things there is just a shitload of googling required.
We also can't just disable them because some of them have settings that the and user wants.

WHAAAA
This has been a nightmare for me to debug and this really needs a shitload of hacking to get right.

If you or anyone else has a holiday free of time and wants to know every little detail about shells feel free to work on this.

[jesseduffield]

@ndowens this should be fixed in the latest version. Please let me know if it's not :)

[jesseduffield]

(also @mjarkk that is a fantastic rant) :)

[ndowens]

@ndowens this should be fixed in the latest version. Please let me know if it's not :)

I updated the package to the latest that was available to Voidlinux yesterday and it didn’t prompt

[mjarkk]

the last release was 20 minutes ago :),
I'm not sure how fast void picks up the update but the version with the fix is v0.10.5.

[ndowens]

the last release was 20 minutes ago :),
I'm not sure how fast void picks up the update but the version with the fix is v0.10.5.

Ah I will update it in void ASAP and try it

[ndowens]

Just updated and still no prompt

[mjarkk]

was it always already like this or started Lazygit doing this since a few updates?

[jesseduffield]

@ndowens what version of lazygit does it display at the bottom right corner? (v0.10.5 is the one we just released)

If you're using a void package it may be that that only uses daily releases

[ndowens]

I gives unversioned

…

On Tue, Nov 12, 2019 at 6:37 AM Jesse Duffield ***@***.***> wrote: @ndowens <https://github.com/ndowens> what version of lazygit does it display at the bottom right corner? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#534?email_source=notifications&email_token=AAA4X3Z5Q5GFRQZCICX22WLQTKPPFA5CNFSM4JL3IU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED2DMPY#issuecomment-552875583>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA4X3ZNXVLOHX7FGTVI4KDQTKPPFANCNFSM4JL3IU4A> .

[jesseduffield]

that's interesting. have you built this via cloning this repo? Or have you used a package manager of some kind

[ndowens]

I packaged it using void’s packaging tools for putting in the repo. Used the release tar file

…

On Tue, Nov 12, 2019 at 6:39 AM Jesse Duffield ***@***.***> wrote: that's interesting. have you built this via cloning this repo? Or have you used a package manager of some kind — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#534?email_source=notifications&email_token=AAA4X34WOWSZVG4H3LE77UTQTKPXVA5CNFSM4JL3IU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED2DR6A#issuecomment-552876280>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA4X35HJLVGSHI5CK4YXQ3QTKPXVANCNFSM4JL3IU4A> .

[jesseduffield]

seems like the void packages don't include version numbers, that's annoying. We may need to wait for the next daily release

[mjarkk]

It's still on 0.10.4