LazyGit exits unpredictably while moving quickly through commits (on WSL only)

[treefitty]

Describe the bug
When I move the cursor (up/down keys) through the commits (reflog) the app crashes. This only happens on WSL, not on my Mac (that works perfectly). Strangely the problem seems to happen less if I use the '-d' debug flag.

To Reproduce
Steps to reproduce the behavior:

1. Open lazygit in any repository directory in WSL
2. Use left/right arrows to move focus to the commits pane
3. Quickly use the up/down keyboard keys to shift focus. While I haven't been able to confirm this, it might be a race condition because some change sets are quite large.

Expected behavior
It should move focus without exiting.
I say "exit" because I get no logs in the console.. so it may not be a "crash" per se.

Desktop (please complete the following information):

• Windows 10 WSL (Microsoft Windows [Version 10.0.18363.592])
• Lazygit Version: commit=, build date=2020-01-10, build source=debian, version=0.13, os=linux, arch=amd64
• ConEmu 191012 [64] Startup Info

Additional context
It may be worth noting that I use "ConEmu" too, so it could be some strangely confluence of circumstances.

[carstengehling]

Same bug at my machine, also with ConEmu (Cmder). I just tried the exact same interactions while using the default "bash console". And in this setup lazygit does not exit. So I am coming to the conclusion, that ConEmu is doing something weird. I'll look more into it.

[jesseduffield]

would either of you happen to have a stack trace of the error, assuming it panics on exit? The fact that the debug flag has an impact tells me it's a concurrency issue and that maybe we need to put a mutex on something.

[jesseduffield]

I've got a PR up that may fix the issue: let me know if it works :) #643

[carstengehling]

would either of you happen to have a stack trace of the error, assuming it panics on exit?

It does not seem to panic - just exit. Unless there is somewhere in WSL where I could look for a logfile?

Thanks for the possible bugifx, I'll try to see if I can build the PR today and test it.

[saulery]

Hello, Same error there. Typing LEFT, RIGHT, UP, DOWN, PGUP, PGDOWN exits the program.

I use ConEmu and gitbash on Windows 7 64 bits SP1.

No stack trace, he just exits.

But in case of typing PGUP, the program exits and displays one tilde.
Sometimes typing UP exits and displays the character A.
Sometimes typing RIGHT exits and displays the character C.

[jesseduffield]

I think I know what's going on: in terminal speak the up key is typically translated into ESC+A, and right is translated into ESC+C. So I think that after pressing a key the terminal is sending an escape sequence to the program but not fast enough to be interpreted as a single escape sequence, meaning it's taken as a literal escape key which therefore exits the program. The details probably differ but that's the gist I'm assuming.

I wonder if it's something to do with the value of the TERM variable. What do you get doing echo $TERM (assuming echo is a command windows recognises) @lkppo @carstengehling @paulcarroll

[treefitty]

That sounds really promising @jesseduffield
Unfortunately i've completely moved from windows to mac recently and can't find that out 🤕 .... perhaps you have some insight @carstengehling ?

[cseickel]

I am having the same problem, using WSL in ConEmu on Windows 10. I am running this in tmux if that makes a difference.

echo $TERM outputs: screen-256color

[jesseduffield]

@carstengehling @lkppo @cseickel could you guys try this out on the latest release? We're using a new rendering library which may fix the issue

[carstengehling]

@jesseduffield I switched away from ConEmu ~8 months ago to use MS' own Windows Terminal instead. I have not experienced any of the above-mentioned problems since.

[carstengehling]

On that note: Lazygit works awesomely with Windows Terminal! I have just upgraded to 0.27.1 (using your PPA), and everything is just so smooth. Mouse integration - including scrolling with the mouse wheel - is just plain cool. :-)