Move package validation enablement to targets

Agent-Logs-Url: https://github.com/jet/equinox/sessions/0e68e429-5b38-4688-9e94-88d2522d81db

Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>

Author: Copilot

Directory.Build.props

@@ -16,7 +16,6 @@
 
     <!-- We want to opt in to publishing nugets per library, but only when CI=true --> 
     <IsPackable>false</IsPackable>
-    <EnablePackageValidation Condition=" '$(CI)' == 'true' and '$(IsPackable)' == 'true' ">true</EnablePackageValidation>
     <PackageOutputPath>$(MSBuildThisFileDirectory)artifacts\nupkg</PackageOutputPath>
     <GenerateDocumentationFile Condition=" '$(CI)' == 'true' and '$(IsPackable)' == 'true' ">true</GenerateDocumentationFile>
   </PropertyGroup>

Directory.Build.targets

@@ -8,6 +8,7 @@
     <Target Name="ComputeFileVersion" BeforeTargets="Build">
         <PropertyGroup>
             <GeneratePackageOnBuild Condition=" '$(CI)' == 'true' and '$(IsPackable)' == 'true' ">true</GeneratePackageOnBuild>
+            <EnablePackageValidation Condition=" '$(CI)' == 'true' and '$(IsPackable)' == 'true' ">true</EnablePackageValidation>
         </PropertyGroup>
     </Target>
-</Project>
+</Project>

src/Directory.Build.props

@@ -3,4 +3,7 @@
     <PropertyGroup>
         <IsPackable>true</IsPackable>
     </PropertyGroup>
+    <ItemGroup Condition="'$(CI)' == 'true' and '$(PackageValidationBaselinePath)' == '' and '$(PackageValidationBaselineVersion)' != ''">
+        <PackageDownload Include="$([MSBuild]::ValueOrDefault('$(PackageValidationBaselineName)', '$(PackageId)'))" Version="[$(PackageValidationBaselineVersion)]" />
+    </ItemGroup>
 </Project>

tools/Directory.Build.props

@@ -3,4 +3,7 @@
     <PropertyGroup>
         <IsPackable>true</IsPackable>
     </PropertyGroup>
+    <ItemGroup Condition="'$(CI)' == 'true' and '$(PackageValidationBaselinePath)' == '' and '$(PackageValidationBaselineVersion)' != ''">
+        <PackageDownload Include="$([MSBuild]::ValueOrDefault('$(PackageValidationBaselineName)', '$(PackageId)'))" Version="[$(PackageValidationBaselineVersion)]" />
+    </ItemGroup>
 </Project>