Remove IsCiBuild and delete package target

Agent-Logs-Url: https://github.com/jet/equinox/sessions/65986a44-e649-4ba0-9e24-08bff4fdda4b

Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>

Author: Copilot

Directory.Build.props

@@ -14,8 +14,7 @@
          Tools and Tests flip this to false in order to ensure we validate with the recent one embdedded in the SDK-->
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
 
-    <IsCiBuild Condition=" '$(CI)' == 'true' or '$(TF_BUILD)' != '' ">true</IsCiBuild>
-    <!-- We want to opt in to publishing nugets per library, but only in CI --> 
+    <!-- We want to opt in to publishing nugets per library, but only when CI=true --> 
     <IsPackable>false</IsPackable>
     <PackageOutputPath>$(MSBuildThisFileDirectory)artifacts\nupkg</PackageOutputPath>
   </PropertyGroup>

Directory.Build.targets

@@ -5,9 +5,4 @@
             <FileVersion>$(MinVerMajor).$(MinVerMinor).$(MinVerPatch).$(BUILD_ID)</FileVersion>
         </PropertyGroup>
     </Target>
-    <Target Name="SetGeneratePackageOnBuild" BeforeTargets="Build">
-        <PropertyGroup>
-            <GeneratePackageOnBuild Condition=" '$(IsCiBuild)' == 'true' and '$(IsPackable)' == 'true' ">true</GeneratePackageOnBuild>
-        </PropertyGroup>
-    </Target>
 </Project>

azure-pipelines.yml

@@ -13,6 +13,7 @@ jobs:
     vmImage: $(vmImage)
   variables:  
     BUILD_ID: $(BUILD.BUILDNUMBER)
+    CI: true
     EQUINOX_INTEGRATION_SKIP_EVENTSTORE: true
     EQUINOX_INTEGRATION_SKIP_COSMOS: true
   steps:

src/Directory.Build.props

@@ -2,7 +2,8 @@
     <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))"/>
     <PropertyGroup>
         <IsPackable>true</IsPackable>
-        <GenerateDocumentationFile Condition=" '$(IsCiBuild)' == 'true' ">true</GenerateDocumentationFile>
-        <EnablePackageValidation Condition=" '$(IsCiBuild)' == 'true' ">true</EnablePackageValidation>
+        <GeneratePackageOnBuild Condition=" '$(CI)' == 'true' ">true</GeneratePackageOnBuild>
+        <GenerateDocumentationFile Condition=" '$(CI)' == 'true' ">true</GenerateDocumentationFile>
+        <EnablePackageValidation Condition=" '$(CI)' == 'true' ">true</EnablePackageValidation>
     </PropertyGroup>
 </Project>

tools/Directory.Build.props

@@ -2,7 +2,8 @@
     <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))"/>
     <PropertyGroup>
         <IsPackable>true</IsPackable>
-        <GenerateDocumentationFile Condition=" '$(IsCiBuild)' == 'true' ">true</GenerateDocumentationFile>
-        <EnablePackageValidation Condition=" '$(IsCiBuild)' == 'true' ">true</EnablePackageValidation>
+        <GeneratePackageOnBuild Condition=" '$(CI)' == 'true' ">true</GeneratePackageOnBuild>
+        <GenerateDocumentationFile Condition=" '$(CI)' == 'true' ">true</GenerateDocumentationFile>
+        <EnablePackageValidation Condition=" '$(CI)' == 'true' ">true</EnablePackageValidation>
     </PropertyGroup>
 </Project>