Skip to content

Commit 798d90c

Browse files
committed
Fix GHCR primary tag by placing version tag last
- Reorder tags: latest → stable → sha → version (last) - GHCR displays the last-created tag as primary - Update esp-idf.yml: idf-v5.4.1 now last - Update platformio.yml: pio-v6.1.18 now last - Update ESP-Matter tags order (still disabled) Documentation: - Update github-actions-standards.mdc - Version tag MUST be last for GHCR to display it as primary - Order: latest, stable, sha, version (last = primary)
1 parent f0e4d1f commit 798d90c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.cursor/rules/github-actions-standards.mdc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,10 @@ jobs:
129129
platforms: linux/amd64,linux/arm64
130130
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
131131
tags: |
132-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:<prefix>-${{ matrix.version }}
133132
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:latest
134133
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:stable
135134
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:sha-${{ steps.tags.outputs.sha_short }}
135+
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:<prefix>-${{ matrix.version }}
136136
cache-from: type=gha,scope=${{ env.<IMAGE_NAME> }}
137137
cache-to: type=gha,mode=max,scope=${{ env.<IMAGE_NAME> }}
138138
build-args: |
@@ -233,8 +233,8 @@ jobs:
233233

234234
**Tag Order (Critical for GHCR Display):**
235235
- List tags in the `tags:` field of `docker/build-push-action`
236-
- **Version tag MUST be first** - GHCR displays the first tag as the primary tag
237-
- Order: `<prefix>-v<version>` (first), `latest`, `stable`, `sha-<commit>` (last)
236+
- **Version tag MUST be last** - GHCR displays the last tag as the primary tag
237+
- Order: `latest`, `stable`, `sha-<commit>`, `<prefix>-v<version>` (last = primary display)
238238
- All tags point to the same multi-arch manifest automatically
239239

240240
## Workflow Testing

.github/workflows/esp-idf.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,10 @@ jobs:
6969
platforms: linux/amd64,linux/arm64
7070
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
7171
tags: |
72-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:idf-${{ matrix.idf_base_tag }}
7372
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:latest
7473
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:stable
7574
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:sha-${{ steps.tags.outputs.sha_short }}
75+
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:idf-${{ matrix.idf_base_tag }}
7676
cache-from: type=gha,scope=${{ env.ESP_IDF_IMAGE_NAME }}
7777
cache-to: type=gha,mode=max,scope=${{ env.ESP_IDF_IMAGE_NAME }}
7878
build-args: |
@@ -119,10 +119,10 @@ jobs:
119119
platforms: linux/amd64,linux/arm64
120120
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
121121
tags: |
122-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:idf-${{ matrix.jethome_idf_base_tag }}-matter-${{ matrix.esp_matter_version }}
123122
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:latest
124123
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:stable
125124
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:sha-${{ steps.tags.outputs.sha_short }}
125+
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:idf-${{ matrix.jethome_idf_base_tag }}-matter-${{ matrix.esp_matter_version }}
126126
cache-from: type=gha,scope=${{ env.ESP_MATTER_IMAGE_NAME }}
127127
cache-to: type=gha,mode=max,scope=${{ env.ESP_MATTER_IMAGE_NAME }}
128128
build-args: |

.github/workflows/platformio.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ jobs:
6565
platforms: linux/amd64,linux/arm64
6666
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
6767
tags: |
68-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:pio-${{ matrix.pio_version }}
6968
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:latest
7069
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:stable
7170
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:sha-${{ steps.tags.outputs.sha_short }}
71+
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:pio-${{ matrix.pio_version }}
7272
cache-from: type=gha,scope=${{ env.PLATFORMIO_IMAGE_NAME }}
7373
cache-to: type=gha,mode=max,scope=${{ env.PLATFORMIO_IMAGE_NAME }}
7474
build-args: |

0 commit comments

Comments
 (0)