Upgrade golangci-lint and fix linting issues (#544)

## Summary
Upgrade golangci-lint and fix linting issues

## How was it tested?
devbox run lint (and CICD)

## Community Contribution License

All community contributions in this pull request are licensed to the
project maintainers under the terms of the [Apache 2
License](https://www.apache.org/licenses/LICENSE-2.0).

By creating this pull request I represent that I have the right to
license the contributions to the project maintainers under the Apache 2
License as stated in the [Community Contribution
License](https://github.com/jetify-com/opensource/blob/main/CONTRIBUTING.md#community-contribution-license).

Author: loreto

devbox.json

@@ -1,9 +1,8 @@
 {
-  "packages": [
-    "go@latest",
-    "golangci-lint@latest",
-    "runx:mvdan/gofumpt@latest",
-  ],
+  "packages": {
+    "go": "latest",
+    "golangci-lint": "latest"
+  },
   "shell": {
     "init_hook": [
       "export \"GOROOT=$(go env GOROOT)\"",
@@ -23,12 +22,7 @@
         "devbox run build",
         "dist/envsec auth login",
       ],
-      "fmt": [
-        "find . -name '*.go' -not -wholename './gen/*' -exec gofumpt -w -l {} \\+",
-        "if [ -n \"$CI\" ]; then",
-        "  git diff --exit-code",
-        "fi"
-      ],
+      "fmt": "golangci-lint run",
     }
   },
   "nixpkgs": {

devbox.lock

@@ -99,10 +99,6 @@
           "store_path": "/nix/store/25732rsdh49iwjrik69sb9cfhiza00b5-golangci-lint-1.64.5"
         }
       }
-    },
-    "runx:mvdan/gofumpt@latest": {
-      "resolved": "mvdan/gofumpt@v0.7.0",
-      "version": "v0.7.0"
     }
   }
 }

internal/build/build.go

@@ -18,9 +18,10 @@ var (
 
 func init() {
 	buildEnv := strings.ToLower(os.Getenv("ENVSEC_BUILD_ENV"))
-	if buildEnv == "prod" {
+	switch buildEnv {
+	case "prod":
 		IsDev = false
-	} else if buildEnv == "dev" {
+	case "dev":
 		IsDev = true
 	}
 }

internal/tux/style.go

@@ -35,7 +35,7 @@ type StyleRule struct {
 	MarginLeft         int
 }
 
-func Render(styleSheet StyleSheet, class string, text string) string {
+func Render(styleSheet StyleSheet, class, text string) string {
 	return text
 }
 
@@ -68,7 +68,7 @@ func Renderer(styleRule StyleRule, tokens map[string]string) StyleRenderer {
 	return renderer
 }
 
-func getColor(token string, invertedToken string, tokens map[string]string) lipgloss.TerminalColor {
+func getColor(token, invertedToken string, tokens map[string]string) lipgloss.TerminalColor {
 	color := resolveToken(token, tokens)
 	invertedColor := resolveToken(invertedToken, tokens)
 
@@ -91,8 +91,8 @@ func resolveToken(token string, tokens map[string]string) string {
 	return token
 }
 
-func StyleFunc(styleSheet StyleSheet) func(class string, text string) string {
-	return func(class string, text string) string {
+func StyleFunc(styleSheet StyleSheet) func(class, text string) string {
+	return func(class, text string) string {
 		styleRule, exists := styleSheet.Styles[class]
 		// Return the text as is if the class is not found.
 		if !exists {

internal/tux/tux.go

@@ -104,7 +104,7 @@ func QuotedTerms(terms []string) []string {
 	return q
 }
 
-func Plural[T any](items []T, singular string, plural string) string {
+func Plural[T any](items []T, singular, plural string) string {
 	if len(items) == 1 {
 		return singular
 	}

pkg/envcli/auth.go

@@ -39,7 +39,7 @@ func loginCmd() *cobra.Command {
 
 			_, err = client.LoginFlow()
 			if err == nil {
-				fmt.Fprintln(cmd.OutOrStdout(), "Logged in successfully")
+				_, _ = fmt.Fprintln(cmd.OutOrStdout(), "Logged in successfully")
 			}
 			return err
 		},
@@ -61,7 +61,7 @@ func logoutCmd() *cobra.Command {
 
 			err = client.LogoutFlow()
 			if err == nil {
-				fmt.Fprintln(cmd.OutOrStdout(), "Logged out successfully")
+				_, _ = fmt.Fprintln(cmd.OutOrStdout(), "Logged out successfully")
 			}
 			return err
 		},

pkg/envcli/download.go

@@ -33,7 +33,7 @@ func DownloadCmd() *cobra.Command {
 		},
 	}
 
-	flags.configFlags.register(command)
+	flags.register(command)
 	command.Flags().StringVarP(
 		&flags.format, "format", "f", "env", "file format: dotenv or json")
 

pkg/envcli/exec.go

@@ -48,6 +48,6 @@ func ExecCmd() *cobra.Command {
 			return commandToRun.Run()
 		},
 	}
-	flags.configFlags.register(command)
+	flags.register(command)
 	return command
 }

pkg/envcli/ls.go

@@ -55,7 +55,7 @@ func ListCmd() *cobra.Command {
 		"table",
 		"format to use for displaying keys and values, one of: table, dotenv, json",
 	)
-	flags.configFlags.register(command)
+	flags.register(command)
 
 	return command
 }

pkg/envcli/rm.go

@@ -27,7 +27,7 @@ func RemoveCmd() *cobra.Command {
 			return cmdCfg.envsec.DeleteAll(cmd.Context(), envNames...)
 		},
 	}
-	flags.configFlags.register(command)
+	flags.register(command)
 
 	return command
 }