Skip to content

Commit 0f86cf8

Browse files
authored
Upgrade golangci-lint and fix linting issues (#544)
## Summary Upgrade golangci-lint and fix linting issues ## How was it tested? devbox run lint (and CICD) ## Community Contribution License All community contributions in this pull request are licensed to the project maintainers under the terms of the [Apache 2 License](https://www.apache.org/licenses/LICENSE-2.0). By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 License as stated in the [Community Contribution License](https://github.com/jetify-com/opensource/blob/main/CONTRIBUTING.md#community-contribution-license).
1 parent 833e320 commit 0f86cf8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

constructors.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ func newTypeID(prefix string, suffixBuf [26]byte) TypeID {
120120

121121
// FromUUID encodes the given UUID (in hex string form) as a TypeID with the given prefix.
122122
// If you want to create an id without a prefix, pass an empty string for the prefix.
123-
func FromUUID(prefix string, uidStr string) (TypeID, error) {
123+
func FromUUID(prefix, uidStr string) (TypeID, error) {
124124
// Validate prefix early
125125
if err := validatePrefix(prefix); err != nil {
126126
return zeroID, err

typeid_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func testInvalidExample(t *testing.T, example InvalidExample) {
235235
}
236236

237237
// testInvalidPrefix tests that all constructors properly reject invalid prefixes
238-
func testInvalidPrefix(t *testing.T, prefix string, desc string) {
238+
func testInvalidPrefix(t *testing.T, prefix, desc string) {
239239
t.Helper()
240240

241241
// Test Generate constructor with invalid prefix

0 commit comments

Comments
 (0)