Skip to content

Commit aa65102

Browse files
Merge pull request #12643 from jetty/jetty-12.0.x-12609-setStatusCodes
Issue #12609 - better validation for response codes in setStatus
2 parents a7de14a + 92d5b92 commit aa65102

File tree

2 files changed

+4
-2
lines changed
  • jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal
  • jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested

2 files changed

+4
-2
lines changed

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,6 +1190,8 @@ public int getStatus()
11901190
@Override
11911191
public void setStatus(int code)
11921192
{
1193+
if (code < 100 || code > 999)
1194+
throw new IllegalArgumentException();
11931195
if (!isCommitted())
11941196
_status = code;
11951197
}

jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/Response.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ public void addIntHeader(String name, int value)
754754
@Override
755755
public void setStatus(int sc)
756756
{
757-
if (sc <= 0)
757+
if (sc < 100 || sc > 999)
758758
throw new IllegalArgumentException();
759759
if (isMutable())
760760
{
@@ -775,7 +775,7 @@ public void setStatus(int sc, String message)
775775

776776
public void setStatusWithReason(int sc, String message)
777777
{
778-
if (sc <= 0)
778+
if (sc < 100 || sc > 999)
779779
throw new IllegalArgumentException();
780780
if (isMutable())
781781
{

0 commit comments

Comments
 (0)