Skip to content

Commit 8ae8d55

Browse files
authored
Merge pull request PolusAI#223 from jfennick/compute_remove_temporarily
temporarily remove legacy Labshare Compute API
2 parents eeaefd6 + 3a31cf0 commit 8ae8d55

File tree

6 files changed

+3
-337
lines changed

6 files changed

+3
-337
lines changed

docs/compute.md

-40
This file was deleted.

docs/dev/api.rst

-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ wic.input_output
2929
------------------------------------
3030
.. automodule:: wic.input_output
3131

32-
wic.labshare
33-
------------------------------------
34-
.. automodule:: wic.labshare
35-
3632
wic.main
3733
------------------------------------
3834
.. automodule:: wic.main

docs/index.rst

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Workflow Inference Compiler documentation
1010
tutorials/tutorials.rst
1111
userguide.md
1212
advanced.md
13-
compute.md
1413
validation.md
1514
dev/installguide.md
1615
dev/devguide.md

src/wic/cli.py

+2-19
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,9 @@
6969
help='Just generates run.sh and exits. Does not actually invoke ./run.sh')
7070
group_run.add_argument('--run_local', default=False, action="store_true",
7171
help='After generating the cwl file(s), run it on your local machine.')
72-
group_run.add_argument('--run_compute', default=False, action="store_true",
73-
help='After generating the cwl file(s), run it on the remote labshare Compute platform.')
74-
parser.add_argument('--compute_driver', type=str, required=False, default='slurm', choices=['slurm', 'argo'],
75-
help='The driver to use for running workflows on labshare Compute.')
76-
# Use required=('--run_compute' in sys.argv) make other args conditionally required.
77-
# See https://stackoverflow.com/questions/19414060/argparse-required-argument-y-if-x-is-present
78-
# For example, if run_compute is enabled, you MUST enable cwl_inline_subworkflows!
79-
# Plugins with 'class: Workflow' (i.e. subworkflows) are not currently supported.
8072

81-
parser.add_argument('--cwl_inline_subworkflows', default=('--run_compute' in sys.argv), action="store_true",
82-
help='Before generating the cwl file, inline all subworkflows. Required for --run_compute')
73+
parser.add_argument('--cwl_inline_subworkflows', default=False, action="store_true",
74+
help='Before generating the cwl file, inline all subworkflows.')
8375
parser.add_argument('--inference_disable', default=False, action="store_true",
8476
help='Disables use of the inference algorithm when compiling.')
8577
parser.add_argument('--inference_use_naming_conventions', default=False, action="store_true",
@@ -95,15 +87,6 @@
9587
parser.add_argument('--cachedir', type=str, required=False, default='cachedir',
9688
help='The directory to save intermediate results; useful with RealtimePlots.py')
9789

98-
AWS_URL = 'http://compute.ci.aws.labshare.org'
99-
NCATS_URL = 'https://compute.scb-ncats.io/'
100-
101-
parser.add_argument('--compute_url', type=str, default=NCATS_URL,
102-
help='The URL associated with the labshare Compute API. Required for --run_compute')
103-
parser.add_argument('--compute_access_token', type=str, required=('--run_compute' in sys.argv),
104-
help="""The access_token used for authentication. Required for --run_compute
105-
For now, get this manually from https://a-qa.labshare.org/""")
106-
10790
parser.add_argument('--graphviz', default=False, action="store_true",
10891
help='Generate a DAG using graphviz.')
10992
parser.add_argument('--graph_label_edges', default=False, action="store_true",

src/wic/labshare.py

-264
This file was deleted.

src/wic/main.py

+1-9
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
from wic.utils_yaml import wic_loader
1313
from . import input_output as io
14-
from . import ast, cli, compiler, inference, inlineing, labshare, plugins, run_local, utils # , utils_graphs
14+
from . import ast, cli, compiler, inference, inlineing, plugins, run_local, utils # , utils_graphs
1515
from .schemas import wic_schema
1616
from .wic_types import GraphData, GraphReps, Json, StepId, Yaml, YamlTree
1717

@@ -161,14 +161,6 @@ def main() -> None:
161161
rose_tree = plugins.cwl_update_outputs_optional_rosetree(rose_tree)
162162
io.write_to_disk(rose_tree, Path('autogenerated/'), True, args.inputs_file)
163163

164-
if args.run_compute:
165-
# Inline compiled CWL if necessary, i.e. inline across scattering boundaries.
166-
# NOTE: Since we need to distribute scattering operations across all dependencies,
167-
# and due to inference, this cannot be done before compilation.
168-
rose_tree = inlineing.inline_subworkflow_cwl(rose_tree)
169-
io.write_to_disk(rose_tree, Path('autogenerated/'), True, args.inputs_file)
170-
labshare.upload_all(rose_tree, tools_cwl, args, True)
171-
172164
if args.graphviz:
173165
if shutil.which('dot'):
174166
# Render the GraphViz diagram

0 commit comments

Comments
 (0)