Skip to content

Commit 743b0e2

Browse files
authored
Add all error-prone checks (#468)
Add all error-prone checks in the project bazelrc
1 parent 22689eb commit 743b0e2

File tree

3 files changed

+379
-3
lines changed

3 files changed

+379
-3
lines changed

.bazelrc

Lines changed: 371 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,373 @@
1-
# https://errorprone.info/
1+
http://errorprone.info/bugpatterns
2+
# To avoid bugs in the code
3+
# P1 Fix the errors and bump from :WARN to :ERROR
4+
# P2 Fix the warnings and bump from :OFF to :WARN
5+
6+
# On by default : ERROR
7+
build --javacopt "-Xep:ArrayEquals:ERROR"
8+
build --javacopt "-Xep:ArrayFillIncompatibleType:ERROR"
9+
build --javacopt "-Xep:ArrayHashCode:ERROR"
10+
build --javacopt "-Xep:ArrayToString:ERROR"
11+
build --javacopt "-Xep:ArraysAsListPrimitiveArray:ERROR"
12+
build --javacopt "-Xep:AsyncCallableReturnsNull:ERROR"
13+
build --javacopt "-Xep:AsyncFunctionReturnsNull:ERROR"
14+
build --javacopt "-Xep:AutoValueConstructorOrderChecker:ERROR"
15+
build --javacopt "-Xep:BadShiftAmount:ERROR"
16+
build --javacopt "-Xep:BundleDeserializationCast:ERROR"
17+
build --javacopt "-Xep:ChainingConstructorIgnoresParameter:ERROR"
18+
build --javacopt "-Xep:CheckReturnValue:ERROR"
19+
build --javacopt "-Xep:CollectionIncompatibleType:ERROR"
20+
build --javacopt "-Xep:ComparableType:ERROR"
21+
build --javacopt "-Xep:ComparingThisWithNull:ERROR"
22+
build --javacopt "-Xep:ComparisonOutOfRange:ERROR"
23+
build --javacopt "-Xep:CompatibleWithAnnotationMisuse:ERROR"
24+
build --javacopt "-Xep:CompileTimeConstant:ERROR"
25+
build --javacopt "-Xep:ComplexBooleanConstant:ERROR"
26+
build --javacopt "-Xep:ConditionalExpressionNumericPromotion:ERROR"
27+
build --javacopt "-Xep:ConstantOverflow:ERROR"
28+
build --javacopt "-Xep:DaggerProvidesNull:ERROR"
29+
build --javacopt "-Xep:DeadException:ERROR"
30+
build --javacopt "-Xep:DeadThread:ERROR"
31+
build --javacopt "-Xep:DoNotCall:ERROR"
32+
build --javacopt "-Xep:EqualsNaN:ERROR"
33+
build --javacopt "-Xep:EqualsReference:ERROR"
34+
build --javacopt "-Xep:EqualsWrongThing:ERROR"
35+
build --javacopt "-Xep:ForOverride:ERROR"
36+
build --javacopt "-Xep:FormatString:ERROR"
37+
build --javacopt "-Xep:FormatStringAnnotation:ERROR"
38+
build --javacopt "-Xep:FunctionalInterfaceMethodChanged:ERROR"
39+
build --javacopt "-Xep:FuturesGetCheckedIllegalExceptionType:ERROR"
40+
build --javacopt "-Xep:GetClassOnAnnotation:ERROR"
41+
build --javacopt "-Xep:GetClassOnClass:ERROR"
42+
build --javacopt "-Xep:GuardedBy:ERROR"
43+
build --javacopt "-Xep:GuiceAssistedInjectScoping:ERROR"
44+
build --javacopt "-Xep:GuiceAssistedParameters:ERROR"
45+
build --javacopt "-Xep:GuiceInjectOnFinalField:ERROR"
46+
build --javacopt "-Xep:HashtableContains:ERROR"
47+
build --javacopt "-Xep:IdentityBinaryExpression:ERROR"
48+
build --javacopt "-Xep:Immutable:ERROR"
49+
build --javacopt "-Xep:ImmutableModification:ERROR"
50+
build --javacopt "-Xep:IncompatibleArgumentType:ERROR"
51+
build --javacopt "-Xep:IndexOfChar:ERROR"
52+
build --javacopt "-Xep:InexactVarargsConditional:ERROR"
53+
build --javacopt "-Xep:InfiniteRecursion:ERROR"
54+
build --javacopt "-Xep:InjectMoreThanOneScopeAnnotationOnClass:ERROR"
55+
build --javacopt "-Xep:InjectOnMemberAndConstructor:ERROR"
56+
build --javacopt "-Xep:InvalidPatternSyntax:ERROR"
57+
build --javacopt "-Xep:InvalidTimeZoneID:ERROR"
58+
build --javacopt "-Xep:IsInstanceOfClass:ERROR"
59+
build --javacopt "-Xep:IsLoggableTagLength:ERROR"
60+
build --javacopt "-Xep:JUnit3TestNotRun:ERROR"
61+
build --javacopt "-Xep:JUnit4ClassAnnotationNonStatic:ERROR"
62+
build --javacopt "-Xep:JUnit4SetUpNotRun:ERROR"
63+
build --javacopt "-Xep:JUnit4TearDownNotRun:ERROR"
64+
build --javacopt "-Xep:JUnit4TestNotRun:ERROR"
65+
build --javacopt "-Xep:JUnitAssertSameCheck:ERROR"
66+
build --javacopt "-Xep:JavaxInjectOnAbstractMethod:ERROR"
67+
build --javacopt "-Xep:LiteByteStringUtf8:ERROR"
68+
build --javacopt "-Xep:LoopConditionChecker:ERROR"
69+
build --javacopt "-Xep:MathRoundIntLong:ERROR"
70+
#build --javacopt "-Xep:MislabeledAndroidString:ERROR"
71+
build --javacopt "-Xep:MissingSuperCall:ERROR"
72+
build --javacopt "-Xep:MissingTestCall:ERROR"
73+
build --javacopt "-Xep:MisusedWeekYear:ERROR"
74+
build --javacopt "-Xep:MockitoCast:ERROR"
75+
build --javacopt "-Xep:MockitoUsage:ERROR"
76+
build --javacopt "-Xep:ModifyingCollectionWithItself:ERROR"
77+
build --javacopt "-Xep:MoreThanOneInjectableConstructor:ERROR"
78+
build --javacopt "-Xep:MustBeClosedChecker:ERROR"
79+
build --javacopt "-Xep:NCopiesOfChar:ERROR"
80+
build --javacopt "-Xep:NonCanonicalStaticImport:ERROR"
81+
build --javacopt "-Xep:NonFinalCompileTimeConstant:ERROR"
82+
build --javacopt "-Xep:NonRuntimeAnnotation:ERROR"
83+
build --javacopt "-Xep:NullTernary:ERROR"
84+
build --javacopt "-Xep:OptionalEquality:ERROR"
85+
build --javacopt "-Xep:OverlappingQualifierAndScopeAnnotation:ERROR"
86+
build --javacopt "-Xep:OverridesJavaxInjectableMethod:ERROR"
87+
build --javacopt "-Xep:PackageInfo:ERROR"
88+
build --javacopt "-Xep:ParcelableCreator:ERROR"
89+
build --javacopt "-Xep:PreconditionsCheckNotNull:ERROR"
90+
build --javacopt "-Xep:PreconditionsCheckNotNullPrimitive:ERROR"
91+
build --javacopt "-Xep:PredicateIncompatibleType:ERROR"
92+
build --javacopt "-Xep:PrivateSecurityContractProtoAccess:ERROR"
93+
build --javacopt "-Xep:ProtoFieldNullComparison:ERROR"
94+
build --javacopt "-Xep:ProtoStringFieldReferenceEquality:ERROR"
95+
build --javacopt "-Xep:ProtocolBufferOrdinal:ERROR"
96+
build --javacopt "-Xep:ProvidesMethodOutsideOfModule:ERROR"
97+
build --javacopt "-Xep:RandomCast:ERROR"
98+
build --javacopt "-Xep:RandomModInteger:ERROR"
99+
build --javacopt "-Xep:RectIntersectReturnValueIgnored:ERROR"
100+
build --javacopt "-Xep:RestrictedApiChecker:ERROR"
101+
build --javacopt "-Xep:ReturnValueIgnored:ERROR"
102+
build --javacopt "-Xep:SelfAssignment:ERROR"
103+
build --javacopt "-Xep:SelfComparison:ERROR"
104+
build --javacopt "-Xep:SelfEquals:ERROR"
105+
build --javacopt "-Xep:ShouldHaveEvenArgs:ERROR"
106+
build --javacopt "-Xep:SizeGreaterThanOrEqualsZero:ERROR"
107+
build --javacopt "-Xep:StreamToString:ERROR"
108+
build --javacopt "-Xep:StringBuilderInitWithChar:ERROR"
109+
build --javacopt "-Xep:SubstringOfZero:ERROR"
110+
build --javacopt "-Xep:SuppressWarningsDeprecated:ERROR"
111+
build --javacopt "-Xep:ThrowIfUncheckedKnownChecked:ERROR"
112+
build --javacopt "-Xep:ThrowNull:ERROR"
113+
build --javacopt "-Xep:TruthSelfEquals:ERROR"
114+
build --javacopt "-Xep:TryFailThrowable:ERROR"
115+
build --javacopt "-Xep:TypeParameterQualifier:ERROR"
116+
build --javacopt "-Xep:UnnecessaryTypeArgument:ERROR"
117+
build --javacopt "-Xep:UnusedAnonymousClass:ERROR"
118+
build --javacopt "-Xep:UnusedCollectionModifiedInPlace:ERROR"
119+
build --javacopt "-Xep:VarTypeName:ERROR"
120+
121+
# On by default : WARNING
122+
build --javacopt "-Xep:AmbiguousMethodReference:WARN"
123+
build --javacopt "-Xep:ArgumentSelectionDefectChecker:WARN"
124+
build --javacopt "-Xep:ArrayAsKeyOfSetOrMap:WARN"
125+
build --javacopt "-Xep:AssertEqualsArgumentOrderChecker:WARN"
126+
build --javacopt "-Xep:AssertThrowsMultipleStatements:WARN"
127+
# TODO(#469) Fix these warnings
128+
build --javacopt "-Xep:AssertionFailureIgnored:OFF"
129+
build --javacopt "-Xep:AutoValueFinalMethods:WARN"
130+
build --javacopt "-Xep:BadAnnotationImplementation:WARN"
131+
build --javacopt "-Xep:BadComparable:WARN"
132+
build --javacopt "-Xep:BadImport:WARN"
133+
build --javacopt "-Xep:BadInstanceof:WARN"
134+
build --javacopt "-Xep:BigDecimalEquals:WARN"
135+
build --javacopt "-Xep:BigDecimalLiteralDouble:WARN"
136+
# TODO(#469) Fix these warnings
137+
build --javacopt "-Xep:BoxedPrimitiveConstructor:OFF"
138+
build --javacopt "-Xep:ByteBufferBackingArray:WARN"
139+
build --javacopt "-Xep:CannotMockFinalClass:WARN"
140+
build --javacopt "-Xep:CanonicalDuration:WARN"
141+
# TODO(#469) Fix these warnings
142+
build --javacopt "-Xep:CatchAndPrintStackTrace:OFF"
143+
build --javacopt "-Xep:CatchFail:WARN"
144+
# TODO(#469) Fix these warnings
145+
build --javacopt "-Xep:ClassCanBeStatic:WARN"
146+
build --javacopt "-Xep:ClassNewInstance:WARN"
147+
build --javacopt "-Xep:CloseableProvides:WARN"
148+
build --javacopt "-Xep:CollectionToArraySafeParameter:WARN"
149+
build --javacopt "-Xep:CollectorShouldNotUseState:WARN"
150+
build --javacopt "-Xep:ComparableAndComparator:WARN"
151+
build --javacopt "-Xep:DateFormatConstant:WARN"
152+
# TODO(#469/#470) Fix these errors and re-enable violation
153+
build --javacopt "-Xep:DefaultCharset:OFF"
154+
# TODO(#469) Fix these warnings
155+
build --javacopt "-Xep:DeprecatedThreadMethods:OFF"
156+
build --javacopt "-Xep:DoubleBraceInitialization:WARN"
157+
build --javacopt "-Xep:DoubleCheckedLocking:WARN"
158+
build --javacopt "-Xep:EqualsGetClass:WARN"
159+
build --javacopt "-Xep:EqualsHashCode:WARN"
160+
build --javacopt "-Xep:EqualsIncompatibleType:WARN"
161+
build --javacopt "-Xep:EqualsUnsafeCast:WARN"
162+
build --javacopt "-Xep:EqualsUsingHashCode:WARN"
163+
build --javacopt "-Xep:ExtendingJUnitAssert:WARN"
2164
# TODO(#222) Increase to error when we build from jflex-1.7.1 with a lexer annotated with
3165
# @SuppressWarnings
4-
build --javacopt "-Xep:FallThrough:WARN"
166+
build --javacopt "-Xep:FallThrough:OFF"
167+
build --javacopt "-Xep:Finally:WARN"
168+
build --javacopt "-Xep:FloatCast:WARN"
169+
build --javacopt "-Xep:FloatingPointAssertionWithinEpsilon:WARN"
170+
build --javacopt "-Xep:FloatingPointLiteralPrecision:WARN"
171+
build --javacopt "-Xep:FragmentInjection:WARN"
172+
build --javacopt "-Xep:FragmentNotInstantiable:WARN"
173+
build --javacopt "-Xep:FutureReturnValueIgnored:WARN"
174+
build --javacopt "-Xep:GetClassOnEnum:WARN"
175+
build --javacopt "-Xep:HidingField:WARN"
176+
build --javacopt "-Xep:ImmutableAnnotationChecker:WARN"
177+
build --javacopt "-Xep:ImmutableEnumChecker:WARN"
178+
build --javacopt "-Xep:IncompatibleModifiers:WARN"
179+
build --javacopt "-Xep:InconsistentCapitalization:WARN"
180+
build --javacopt "-Xep:InconsistentHashCode:WARN"
181+
# TODO(#469) Fix these warnings
182+
build --javacopt "-Xep:IncrementInForLoopAndHeader:OFF"
183+
build --javacopt "-Xep:InjectOnConstructorOfAbstractClass:WARN"
184+
build --javacopt "-Xep:InputStreamSlowMultibyteRead:WARN"
185+
build --javacopt "-Xep:InstanceOfAndCastMatchWrongType:WARN"
186+
build --javacopt "-Xep:IntLongMath:WARN"
187+
build --javacopt "-Xep:IterableAndIterator:WARN"
188+
build --javacopt "-Xep:JUnit3FloatingPointComparisonWithoutDelta:WARN"
189+
build --javacopt "-Xep:JUnit4ClassUsedInJUnit3:WARN"
190+
build --javacopt "-Xep:JUnitAmbiguousTestClass:WARN"
191+
build --javacopt "-Xep:JavaLangClash:WARN"
192+
# TODO(#469) Fix these warnings
193+
build --javacopt "-Xep:JdkObsolete:OFF"
194+
build --javacopt "-Xep:LockNotBeforeTry:WARN"
195+
build --javacopt "-Xep:LogicalAssignment:WARN"
196+
build --javacopt "-Xep:MathAbsoluteRandom:WARN"
197+
build --javacopt "-Xep:MissingCasesInEnumSwitch:WARN"
198+
build --javacopt "-Xep:MissingFail:WARN"
199+
# TODO(#469) Fix these warnings
200+
build --javacopt "-Xep:MissingOverride:OFF"
201+
build --javacopt "-Xep:ModifiedButNotUsed:WARN"
202+
build --javacopt "-Xep:ModifyCollectionInEnhancedForLoop:WARN"
203+
build --javacopt "-Xep:MultipleParallelOrSequentialCalls:WARN"
204+
build --javacopt "-Xep:MutableConstantField:WARN"
205+
build --javacopt "-Xep:NarrowingCompoundAssignment:WARN"
206+
build --javacopt "-Xep:NestedInstanceOfConditions:WARN"
207+
build --javacopt "-Xep:NonAtomicVolatileUpdate:WARN"
208+
build --javacopt "-Xep:NonOverridingEquals:WARN"
209+
build --javacopt "-Xep:NullableConstructor:WARN"
210+
build --javacopt "-Xep:NullablePrimitive:WARN"
211+
build --javacopt "-Xep:NullableVoid:WARN"
212+
build --javacopt "-Xep:ObjectToString:WARN"
213+
build --javacopt "-Xep:ObjectsHashCodePrimitive:WARN"
214+
build --javacopt "-Xep:OperatorPrecedence:WARN"
215+
build --javacopt "-Xep:OptionalNotPresent:WARN"
216+
build --javacopt "-Xep:OrphanedFormatString:WARN"
217+
build --javacopt "-Xep:OverrideThrowableToString:WARN"
218+
build --javacopt "-Xep:Overrides:WARN"
219+
build --javacopt "-Xep:OverridesGuiceInjectableMethod:WARN"
220+
build --javacopt "-Xep:ParameterName:WARN"
221+
build --javacopt "-Xep:PreconditionsInvalidPlaceholder:WARN"
222+
build --javacopt "-Xep:ProtoRedundantSet:WARN"
223+
build --javacopt "-Xep:QualifierOrScopeOnInjectMethod:WARN"
224+
build --javacopt "-Xep:ReachabilityFenceUsage:WARN"
225+
# TODO(#469) Fix these warnings
226+
build --javacopt "-Xep:ReferenceEquality:OFF"
227+
build --javacopt "-Xep:RequiredModifiers:WARN"
228+
build --javacopt "-Xep:ShortCircuitBoolean:WARN"
229+
build --javacopt "-Xep:StaticGuardedByInstance:WARN"
230+
build --javacopt "-Xep:StreamResourceLeak:WARN"
231+
build --javacopt "-Xep:StringSplitter:WARN"
232+
build --javacopt "-Xep:SwigMemoryLeak:WARN"
233+
build --javacopt "-Xep:SynchronizeOnNonFinalField:WARN"
234+
build --javacopt "-Xep:ThreadJoinLoop:WARN"
235+
build --javacopt "-Xep:ThreadLocalUsage:WARN"
236+
# TODO(#469) Fix these warnings
237+
build --javacopt "-Xep:ThreadPriorityCheck:OFF"
238+
build --javacopt "-Xep:ThreeLetterTimeZoneID:WARN"
239+
build --javacopt "-Xep:ToStringReturnsNull:WARN"
240+
build --javacopt "-Xep:TruthAssertExpected:WARN"
241+
build --javacopt "-Xep:TruthConstantAsserts:WARN"
242+
build --javacopt "-Xep:TruthIncompatibleType:WARN"
243+
build --javacopt "-Xep:TypeNameShadowing:WARN"
244+
build --javacopt "-Xep:TypeParameterShadowing:WARN"
245+
build --javacopt "-Xep:TypeParameterUnusedInFormals:WARN"
246+
build --javacopt "-Xep:URLEqualsHashCode:WARN"
247+
build --javacopt "-Xep:UndefinedEquals:WARN"
248+
# TODO(#469) Fix these warnings
249+
build --javacopt "-Xep:UnnecessaryParentheses:OFF"
250+
build --javacopt "-Xep:UnsafeFinalization:WARN"
251+
build --javacopt "-Xep:UnsafeReflectiveConstructionCast:WARN"
252+
build --javacopt "-Xep:UnsynchronizedOverridesSynchronized:WARN"
253+
build --javacopt "-Xep:UseCorrectAssertInTests:WARN"
254+
build --javacopt "-Xep:VariableNameSameAsType:WARN"
255+
build --javacopt "-Xep:WaitNotInLoop:WARN"
256+
build --javacopt "-Xep:WakelockReleasedDangerously:WARN"
257+
258+
#Experimental : ERROR
259+
#build --javacopt "-Xep:AndroidJdkLibsChecker:ERROR"
260+
build --javacopt "-Xep:AssistedInjectAndInjectOnSameConstructor:ERROR"
261+
build --javacopt "-Xep:AutoFactoryAtInject:ERROR"
262+
build --javacopt "-Xep:ClassName:ERROR"
263+
build --javacopt "-Xep:ComparisonContractViolated:ERROR"
264+
build --javacopt "-Xep:DepAnn:ERROR"
265+
build --javacopt "-Xep:DivZero:ERROR"
266+
build --javacopt "-Xep:EmptyIf:ERROR"
267+
build --javacopt "-Xep:FuzzyEqualsShouldNotBeUsedInEqualsMethod:ERROR"
268+
build --javacopt "-Xep:InjectInvalidTargetingOnScopingAnnotation:ERROR"
269+
build --javacopt "-Xep:InjectMoreThanOneQualifier:ERROR"
270+
build --javacopt "-Xep:InjectScopeAnnotationOnInterfaceOrAbstractClass:ERROR"
271+
build --javacopt "-Xep:InjectScopeOrQualifierAnnotationRetention:ERROR"
272+
build --javacopt "-Xep:InjectedConstructorAnnotations:ERROR"
273+
build --javacopt "-Xep:InsecureCryptoUsage:ERROR"
274+
build --javacopt "-Xep:IterablePathParameter:ERROR"
275+
build --javacopt "-Xep:JMockTestWithoutRunWithOrRuleAnnotation:ERROR"
276+
build --javacopt "-Xep:Java7ApiChecker:ERROR"
277+
build --javacopt "-Xep:JavaxInjectOnFinalField:ERROR"
278+
build --javacopt "-Xep:LockMethodChecker:ERROR"
279+
build --javacopt "-Xep:LongLiteralLowerCaseSuffix:ERROR"
280+
build --javacopt "-Xep:NoAllocation:ERROR"
281+
build --javacopt "-Xep:NumericEquality:ERROR"
282+
build --javacopt "-Xep:ParameterPackage:ERROR"
283+
build --javacopt "-Xep:RestrictTo:ERROR"
284+
build --javacopt "-Xep:StaticOrDefaultInterfaceMethod:ERROR"
285+
build --javacopt "-Xep:UnlockMethod:ERROR"
286+
287+
# Experimental : WARNING
288+
build --javacopt "-Xep:AnnotateFormatMethod:WARN"
289+
build --javacopt "-Xep:AnnotationPosition:WARN"
290+
build --javacopt "-Xep:AssertFalse:WARN"
291+
build --javacopt "-Xep:AssistedInjectAndInjectOnConstructors:WARN"
292+
build --javacopt "-Xep:BinderIdentityRestoredDangerously:WARN"
293+
build --javacopt "-Xep:BindingToUnqualifiedCommonType:WARN"
294+
# TODO(#469) Fix these errors and re-enable violation
295+
build --javacopt "-Xep:ConstructorInvokesOverridable:OFF"
296+
build --javacopt "-Xep:ConstructorLeaksThis:WARN"
297+
build --javacopt "-Xep:EmptyTopLevelDeclaration:WARN"
298+
build --javacopt "-Xep:EqualsBrokenForNull:WARN"
299+
build --javacopt "-Xep:ExpectedExceptionChecker:WARN"
300+
build --javacopt "-Xep:FunctionalInterfaceClash:WARN"
301+
build --javacopt "-Xep:HardCodedSdCardPath:WARN"
302+
# TODO(#469) Fix these errors and re-enable violation
303+
build --javacopt "-Xep:InconsistentOverloads:OFF"
304+
build --javacopt "-Xep:InvalidParam:WARN"
305+
build --javacopt "-Xep:InvalidTag:WARN"
306+
build --javacopt "-Xep:InvalidThrows:WARN"
307+
# TODO(#469) Fix these errors and re-enable violation
308+
build --javacopt "-Xep:MissingDefault:OFF"
309+
build --javacopt "-Xep:MutableMethodReturnType:WARN"
310+
build --javacopt "-Xep:NoFunctionalReturnType:WARN"
311+
build --javacopt "-Xep:NonCanonicalStaticMemberImport:WARN"
312+
build --javacopt "-Xep:NullableDereference:WARN"
313+
build --javacopt "-Xep:PrimitiveArrayPassedToVarargsMethod:WARN"
314+
build --javacopt "-Xep:ProtosAsKeyOfSetOrMap:WARN"
315+
build --javacopt "-Xep:ProvidesFix:WARN"
316+
build --javacopt "-Xep:QualifierWithTypeUse:WARN"
317+
build --javacopt "-Xep:RedundantThrows:WARN"
318+
build --javacopt "-Xep:ReturnFromVoid:WARN"
319+
build --javacopt "-Xep:StaticQualifiedUsingExpression:WARN"
320+
build --javacopt "-Xep:StringEquality:WARN"
321+
build --javacopt "-Xep:SystemExitOutsideMain:WARN"
322+
build --javacopt "-Xep:TestExceptionChecker:WARN"
323+
build --javacopt "-Xep:UnnecessaryDefaultInEnumSwitch:WARN"
324+
# TODO(#469) Fix these warnings
325+
build --javacopt "-Xep:Unused:OFF"
326+
# TODO(#469) Fix these warnings
327+
build --javacopt "-Xep:UnusedException:OFF"
328+
# TODO(#469) Fix these warnings
329+
# bazel-out/darwin-fastbuild/genfiles/jflex/LexParse.java:2260: error: [Var] Non-constant variable missing @Var annotation
330+
# RegExp RESULT =null;
331+
build --javacopt "-Xep:Var:OFF"
332+
333+
# Experimental : SUGGESTION
334+
build --javacopt "-Xep:ClassNamedLikeTypeParameter:WARN"
335+
# TODO(#469) Fix these warnings
336+
build --javacopt "-Xep:ConstantField:OFF"
337+
build --javacopt "-Xep:EmptySetMultibindingContributions:WARN"
338+
build --javacopt "-Xep:ExpectedExceptionRefactoring:WARN"
339+
# TODO(#469) Fix these warnings
340+
build --javacopt "-Xep:FieldCanBeFinal:OFF"
341+
build --javacopt "-Xep:FieldMissingNullable:WARN"
342+
build --javacopt "-Xep:ImmutableRefactoring:WARN"
343+
build --javacopt "-Xep:LambdaFunctionalInterface:WARN"
344+
build --javacopt "-Xep:MethodCanBeStatic:WARN"
345+
# TODO(#469) Fix these warnings
346+
build --javacopt "-Xep:MixedArrayDimensions:OFF"
347+
# TODO(#469) Fix these warnings
348+
build --javacopt "-Xep:MultiVariableDeclaration:OFF"
349+
build --javacopt "-Xep:MultipleTopLevelClasses:WARN"
350+
build --javacopt "-Xep:MultipleUnaryOperatorsInMethodCall:WARN"
351+
build --javacopt "-Xep:PackageLocation:WARN"
352+
build --javacopt "-Xep:ParameterComment:WARN"
353+
build --javacopt "-Xep:ParameterNotNullable:WARN"
354+
build --javacopt "-Xep:PrivateConstructorForNoninstantiableModule:WARN"
355+
build --javacopt "-Xep:PrivateConstructorForUtilityClass:WARN"
356+
# TODO(#469) Fix these warnings
357+
build --javacopt "-Xep:RemoveUnusedImports:OFF"
358+
# TODO(#469) Fix these warnings
359+
build --javacopt "-Xep:ReturnMissingNullable:OFF"
360+
build --javacopt "-Xep:ScopeOnModule:WARN"
361+
build --javacopt "-Xep:SwitchDefault:WARN"
362+
build --javacopt "-Xep:TestExceptionRefactoring:WARN"
363+
build --javacopt "-Xep:ThrowsUncheckedException:WARN"
364+
# TODO(#469) Fix these warnings
365+
build --javacopt "-Xep:TryFailRefactoring:OFF"
366+
build --javacopt "-Xep:TypeParameterNaming:WARN"
367+
# TODO(#469) Fix these warnings
368+
build --javacopt "-Xep:UngroupedOverloads:OFF"
369+
build --javacopt "-Xep:UnnecessarySetDefault:WARN"
370+
build --javacopt "-Xep:UnnecessaryStaticImport:WARN"
371+
build --javacopt "-Xep:UseBinds:WARN"
372+
# TODO(#469) Fix these warnings
373+
build --javacopt "-Xep:WildcardImport:OFF"

cup/cup_runtime/BUILD

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,8 @@ licenses(["notice"]) # BSD-like
22
java_library(
33
name = "cup_runtime",
44
srcs = glob(["src/main/java/**/*.java"]),
5-
visibility=["//visibility:public"]
5+
visibility=["//visibility:public"],
6+
javacopts=[
7+
# Not our code, there is nothing we can do
8+
"-XepDisableAllChecks"],
69
)

testsuite/bzltestsuite/java/jflex/testing/javac/BUILD

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,8 @@ java_library(
66
deps = [
77
"//third_party/com/google/guava",
88
],
9+
javacopts = [
10+
# Only used for testing
11+
"-Xep:Java7ApiChecker:OFF",
12+
],
913
)

0 commit comments

Comments
 (0)