[runtime] add runtime chart #2143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
Author
|
recheck |
rahulsadanandan
approved these changes
Dec 24, 2025
oumkale
reviewed
Dec 24, 2025
| @@ -0,0 +1,2 @@ | |||
| ## Change Log | |||
Member
There was a problem hiding this comment.
Hi @levikobi,
Please refer to the JFrog Platform chart changelog and add the relevant information. This is the source to track changes.
oumkale
reviewed
Dec 24, 2025
| @@ -0,0 +1,2 @@ | |||
| Runtime service v{{ .Values.runtime.image.tag | default .Chart.AppVersion }} has been deployed successfully on {{ .Release.Namespace }} namespace! | |||
Member
There was a problem hiding this comment.
Will you please add a check for jfrogurl, joinKey and masterKey? Ref: https://github.com/jfrog/charts/blob/master/stable/artifactory/templates/NOTES.txt
oumkale
reviewed
Dec 24, 2025
| # Declare variables to be passed into your templates. | ||
|
|
||
| imagePullSecrets: | ||
| - name: "docker-jfrog-io-pull-secret" |
Member
There was a problem hiding this comment.
Please remove hard coded values
oumkale
reviewed
Dec 24, 2025
|
|
||
| isMultiTenant: false | ||
|
|
||
| global: |
Member
There was a problem hiding this comment.
Please move global to top, and remove unwated code
Member
Author
|
As discussed with @chukka, we will close this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
Adds the Runtime chart to the JFrog charts repository.
Jira ticket - https://jfrog-int.atlassian.net/browse/RNTM-2387