Add Author attribute for test mocks (#856)

Author: attiasas

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/golang/mock v1.6.0
 	github.com/google/go-github/v45 v45.2.0
 	github.com/jfrog/build-info-go v1.10.10
-	github.com/jfrog/froggit-go v1.16.2
+	github.com/jfrog/froggit-go v1.17.0
 	github.com/jfrog/gofrog v1.7.6
 	github.com/jfrog/jfrog-cli-artifactory v0.2.1
 	github.com/jfrog/jfrog-cli-core/v2 v2.58.2
@@ -127,4 +127,4 @@ replace github.com/jfrog/jfrog-cli-security => github.com/jfrog/jfrog-cli-securi
 
 replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.28.1-0.20250402063549-14e8fd119680
 
-// replace github.com/jfrog/froggit-go => github.com/jfrog/froggit-go dev
+// replace github.com/jfrog/froggit-go => github.com/jfrog/froggit-go master

go.sum

@@ -124,8 +124,8 @@ github.com/jfrog/archiver/v3 v3.6.1 h1:LOxnkw9pOn45DzCbZNFV6K0+6dCsQ0L8mR3ZcujO5
 github.com/jfrog/archiver/v3 v3.6.1/go.mod h1:VgR+3WZS4N+i9FaDwLZbq+jeU4B4zctXL+gL4EMzfLw=
 github.com/jfrog/build-info-go v1.10.10 h1:2nOFjV7SX1uisi2rQK7fb4Evm7YkSOdmssrm6Tf4ipc=
 github.com/jfrog/build-info-go v1.10.10/go.mod h1:JcISnovFXKx3wWf3p1fcMmlPdt6adxScXvoJN4WXqIE=
-github.com/jfrog/froggit-go v1.16.2 h1:F//S83iXH14qsCwYzv0zB2JtjS2pJVEsUoEmYA+37dQ=
-github.com/jfrog/froggit-go v1.16.2/go.mod h1:5VpdQfAcbuyFl9x/x8HGm7kVk719kEtW/8YJFvKcHPA=
+github.com/jfrog/froggit-go v1.17.0 h1:20Ie787WO27SwB2MOHDvsR6yN7fA5WfRnuAbmUqz1Zs=
+github.com/jfrog/froggit-go v1.17.0/go.mod h1:HvDkfFfJwIdsXFdqaB+utvD2cLDRmaC3kF8otYb6Chw=
 github.com/jfrog/gofrog v1.7.6 h1:QmfAiRzVyaI7JYGsB7cxfAJePAZTzFz0gRWZSE27c6s=
 github.com/jfrog/gofrog v1.7.6/go.mod h1:ntr1txqNOZtHplmaNd7rS4f8jpA5Apx8em70oYEe7+4=
 github.com/jfrog/jfrog-apps-config v1.0.1 h1:mtv6k7g8A8BVhlHGlSveapqf4mJfonwvXYLipdsOFMY=

scanpullrequest/scanallpullrequests_test.go

@@ -215,7 +215,7 @@ func getMockClient(t *testing.T, frogbotMessages *[]string, mockParams ...MockPa
 		sourceBranchInfo := vcsclient.BranchInfo{Name: params.sourceBranchName, Repository: params.repoName, Owner: params.repoOwner}
 		targetBranchInfo := vcsclient.BranchInfo{Name: params.targetBranchName, Repository: params.repoName, Owner: params.repoOwner}
 		// Return 2 pull requests to scan, the first with issues the second "clean".
-		client.EXPECT().ListOpenPullRequests(context.Background(), params.repoOwner, params.repoName).Return([]vcsclient.PullRequestInfo{{ID: 1, Source: sourceBranchInfo, Target: targetBranchInfo}, {ID: 2, Source: targetBranchInfo, Target: targetBranchInfo}}, nil)
+		client.EXPECT().ListOpenPullRequests(context.Background(), params.repoOwner, params.repoName).Return([]vcsclient.PullRequestInfo{{ID: 1, Source: sourceBranchInfo, Target: targetBranchInfo, Author: "a"}, {ID: 2, Source: targetBranchInfo, Target: targetBranchInfo, Author: "a"}}, nil)
 		// Return empty comments slice so expect the code to scan both pull requests.
 		client.EXPECT().ListPullRequestComments(context.Background(), params.repoOwner, params.repoName, gomock.Any()).Return([]vcsclient.CommentInfo{}, nil).AnyTimes()
 		client.EXPECT().ListPullRequestReviewComments(context.Background(), params.repoOwner, params.repoName, gomock.Any()).Return([]vcsclient.CommentInfo{}, nil).AnyTimes()

scanrepository/scanrepository_test.go

@@ -260,6 +260,7 @@ pr body
 [comment]: <> (Checksum: 01373ac4d2c32e7da9be22f3e4b4e665)
 pr body
  `
+	userLogin := "user"
 	tests := []struct {
 		testName                string
 		expectedUpdate          bool
@@ -278,6 +279,7 @@ pr body
 					Label: &targetLabel,
 					Repo:  &github.Repository{Name: &targetBranchName, Owner: &github.User{}},
 				},
+				User: &github.User{Login: &userLogin},
 				Body: &firstBody,
 			}},
 		},
@@ -294,6 +296,7 @@ pr body
 					Label: &targetLabel,
 					Repo:  &github.Repository{Name: &targetBranchName, Owner: &github.User{}},
 				},
+				User: &github.User{Login: &userLogin},
 				Body: &secondBody,
 			}},
 		},

testdata/scanpullrequest/expectedPullRequestDetailsResponse.json

@@ -6,5 +6,8 @@
   "description": "this is pr description",
   "state": "opened",
   "target_branch": "master",
-  "source_branch": "pr"
+  "source_branch": "pr",
+  "author": {
+    "username": "testuser"
+  }
 }