|
| 1 | +package common |
| 2 | + |
| 3 | +import ( |
| 4 | + "errors" |
| 5 | + "fmt" |
| 6 | + "testing" |
| 7 | + |
| 8 | + "github.com/jfrog/jfrog-cli-core/v2/utils/config" |
| 9 | + "github.com/jfrog/jfrog-client-go/artifactory" |
| 10 | + "github.com/jfrog/jfrog-client-go/artifactory/services" |
| 11 | + servicesutils "github.com/jfrog/jfrog-client-go/artifactory/services/utils" |
| 12 | + "github.com/stretchr/testify/assert" |
| 13 | + "github.com/stretchr/testify/require" |
| 14 | +) |
| 15 | + |
| 16 | +// statusCodeError mimics jfrog-client-go response errors with HTTP status codes. |
| 17 | +type statusCodeError struct{ code int } |
| 18 | + |
| 19 | +func (e statusCodeError) Error() string { return fmt.Sprintf("http status %d", e.code) } |
| 20 | +func (e statusCodeError) StatusCode() int { return e.code } |
| 21 | + |
| 22 | +var err404 = statusCodeError{code: 404} |
| 23 | + |
| 24 | +// mockSkillsServicesManager mocks ListSkillVersions and FolderInfo for testing. |
| 25 | +type mockSkillsServicesManager struct { |
| 26 | + artifactory.EmptyArtifactoryServicesManager |
| 27 | + listSkillVersionsFunc func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) |
| 28 | + folderInfoFunc func(path string) (*servicesutils.FolderInfo, error) |
| 29 | +} |
| 30 | + |
| 31 | +func (m *mockSkillsServicesManager) ListSkillVersions(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 32 | + return m.listSkillVersionsFunc(repoKey, slug, limit, cursor) |
| 33 | +} |
| 34 | + |
| 35 | +func (m *mockSkillsServicesManager) FolderInfo(path string) (*servicesutils.FolderInfo, error) { |
| 36 | + if m.folderInfoFunc != nil { |
| 37 | + return m.folderInfoFunc(path) |
| 38 | + } |
| 39 | + return nil, nil |
| 40 | +} |
| 41 | + |
| 42 | +func TestListVersionsFromManager_SinglePage_OneCall(t *testing.T) { |
| 43 | + calls := 0 |
| 44 | + mock := &mockSkillsServicesManager{ |
| 45 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 46 | + calls++ |
| 47 | + assert.Equal(t, "my-repo", repoKey) |
| 48 | + assert.Equal(t, "my-skill", slug) |
| 49 | + assert.Equal(t, skillVersionsPageSize, limit) |
| 50 | + assert.Equal(t, "", cursor) |
| 51 | + return []services.SkillVersion{{Version: "1.0.1"}}, "", nil |
| 52 | + }, |
| 53 | + } |
| 54 | + |
| 55 | + versions, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 56 | + require.NoError(t, err) |
| 57 | + assert.Equal(t, []services.SkillVersion{{Version: "1.0.1"}}, versions) |
| 58 | + assert.Equal(t, 1, calls, "a skill within the page limit must resolve in exactly one call") |
| 59 | +} |
| 60 | + |
| 61 | +func TestListVersionsFromManager_PaginatesUntilCursorEmpty(t *testing.T) { |
| 62 | + pages := [][]services.SkillVersion{ |
| 63 | + {{Version: "1.0.3"}, {Version: "1.0.2"}}, |
| 64 | + {{Version: "1.0.1"}}, |
| 65 | + } |
| 66 | + nextCursors := []string{"1.0.2", ""} |
| 67 | + call := 0 |
| 68 | + mock := &mockSkillsServicesManager{ |
| 69 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 70 | + if call == 0 { |
| 71 | + assert.Equal(t, "", cursor, "first call must start from the beginning") |
| 72 | + } else { |
| 73 | + assert.Equal(t, nextCursors[call-1], cursor, "must resume from the previous page's cursor") |
| 74 | + } |
| 75 | + page, next := pages[call], nextCursors[call] |
| 76 | + call++ |
| 77 | + return page, next, nil |
| 78 | + }, |
| 79 | + } |
| 80 | + |
| 81 | + versions, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 82 | + require.NoError(t, err) |
| 83 | + assert.Equal(t, []services.SkillVersion{{Version: "1.0.3"}, {Version: "1.0.2"}, {Version: "1.0.1"}}, versions) |
| 84 | + assert.Equal(t, 2, call, "must stop as soon as nextCursor is empty") |
| 85 | +} |
| 86 | + |
| 87 | +func TestListVersionsFromManager_StopsOnNonAdvancingCursor(t *testing.T) { |
| 88 | + // Guard against infinite loops on stuck cursors. |
| 89 | + calls := 0 |
| 90 | + mock := &mockSkillsServicesManager{ |
| 91 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 92 | + calls++ |
| 93 | + if calls > 3 { |
| 94 | + t.Fatalf("listVersionsFromManager did not stop on a non-advancing cursor") |
| 95 | + } |
| 96 | + return []services.SkillVersion{{Version: "1.0.1"}}, "stuck-cursor", nil |
| 97 | + }, |
| 98 | + } |
| 99 | + |
| 100 | + _, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 101 | + require.Error(t, err) |
| 102 | + assert.Contains(t, err.Error(), "non-advancing cursor") |
| 103 | + assert.LessOrEqual(t, calls, 2, "must stop as soon as the cursor repeats") |
| 104 | +} |
| 105 | + |
| 106 | +func TestListVersionsFromManager_NotFound_RepoMissing(t *testing.T) { |
| 107 | + mock := &mockSkillsServicesManager{ |
| 108 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 109 | + return nil, "", err404 |
| 110 | + }, |
| 111 | + folderInfoFunc: func(path string) (*servicesutils.FolderInfo, error) { |
| 112 | + assert.Equal(t, "my-repo", path) |
| 113 | + return nil, err404 |
| 114 | + }, |
| 115 | + } |
| 116 | + |
| 117 | + _, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 118 | + require.Error(t, err) |
| 119 | + assert.Contains(t, err.Error(), "repository 'my-repo' not found") |
| 120 | +} |
| 121 | + |
| 122 | +func TestListVersionsFromManager_NotFound_SkillMissing(t *testing.T) { |
| 123 | + mock := &mockSkillsServicesManager{ |
| 124 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 125 | + return nil, "", err404 |
| 126 | + }, |
| 127 | + folderInfoFunc: func(path string) (*servicesutils.FolderInfo, error) { |
| 128 | + return &servicesutils.FolderInfo{}, nil |
| 129 | + }, |
| 130 | + } |
| 131 | + |
| 132 | + _, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 133 | + require.Error(t, err) |
| 134 | + assert.Contains(t, err.Error(), "skill 'my-skill' not found in repository 'my-repo'") |
| 135 | +} |
| 136 | + |
| 137 | +func TestListVersionsFromManager_NotFoundMidPagination_NotDisambiguated(t *testing.T) { |
| 138 | + // 404 mid-pagination should not trigger disambiguation (only first-page 404s do). |
| 139 | + call := 0 |
| 140 | + folderInfoCalled := false |
| 141 | + mock := &mockSkillsServicesManager{ |
| 142 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 143 | + call++ |
| 144 | + if call == 1 { |
| 145 | + return []services.SkillVersion{{Version: "1.0.2"}}, "1.0.2", nil |
| 146 | + } |
| 147 | + return nil, "", err404 |
| 148 | + }, |
| 149 | + folderInfoFunc: func(path string) (*servicesutils.FolderInfo, error) { |
| 150 | + folderInfoCalled = true |
| 151 | + return &servicesutils.FolderInfo{}, nil |
| 152 | + }, |
| 153 | + } |
| 154 | + |
| 155 | + _, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 156 | + require.Error(t, err) |
| 157 | + assert.NotContains(t, err.Error(), "not found in repository") |
| 158 | + assert.False(t, folderInfoCalled, "disambiguation must only run on the first page's 404") |
| 159 | +} |
| 160 | + |
| 161 | +func TestListVersionsFromManager_NonNotFoundError_Propagated(t *testing.T) { |
| 162 | + boom := errors.New("network exploded") |
| 163 | + mock := &mockSkillsServicesManager{ |
| 164 | + listSkillVersionsFunc: func(repoKey, slug string, limit int, cursor string) ([]services.SkillVersion, string, error) { |
| 165 | + return nil, "", boom |
| 166 | + }, |
| 167 | + } |
| 168 | + |
| 169 | + _, err := listVersionsFromManager(mock, "my-repo", "my-skill") |
| 170 | + require.Error(t, err) |
| 171 | + assert.ErrorIs(t, err, boom) |
| 172 | +} |
| 173 | + |
| 174 | +func TestListVersions_ValidationErrors(t *testing.T) { |
| 175 | + t.Run("nil server details", func(t *testing.T) { |
| 176 | + _, err := ListVersions(nil, "repo", "slug") |
| 177 | + require.Error(t, err) |
| 178 | + assert.Contains(t, err.Error(), "server details are required") |
| 179 | + }) |
| 180 | + |
| 181 | + t.Run("empty repo key", func(t *testing.T) { |
| 182 | + _, err := ListVersions(&config.ServerDetails{Url: "https://example.com/"}, " ", "slug") |
| 183 | + require.Error(t, err) |
| 184 | + assert.Contains(t, err.Error(), "repository is required") |
| 185 | + }) |
| 186 | + |
| 187 | + t.Run("empty slug", func(t *testing.T) { |
| 188 | + _, err := ListVersions(&config.ServerDetails{Url: "https://example.com/"}, "repo", " ") |
| 189 | + require.Error(t, err) |
| 190 | + assert.Contains(t, err.Error(), "skill name is required") |
| 191 | + }) |
| 192 | +} |
0 commit comments