-
Notifications
You must be signed in to change notification settings - Fork 20
/
Copy pathvisitor.go
270 lines (233 loc) · 6.72 KB
/
visitor.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
package goconst
import (
"go/ast"
"go/constant"
"go/token"
"go/types"
"regexp"
"strconv"
"strings"
)
// treeVisitor is used to walk the AST and find strings that could be constants.
type treeVisitor struct {
fileSet *token.FileSet
typeInfo *types.Info
packageName string
p *Parser
ignoreRegex *regexp.Regexp
}
// Visit browses the AST tree for strings that could be potentially
// replaced by constants.
// A map of existing constants is built as well (-match-constant).
func (v *treeVisitor) Visit(node ast.Node) ast.Visitor {
if node == nil {
return v
}
// A single case with "ast.BasicLit" would be much easier
// but then we wouldn't be able to tell in which context
// the string is defined (could be a constant definition).
switch t := node.(type) {
// Scan for constants in an attempt to match strings with existing constants
case *ast.GenDecl:
if !v.p.matchConstant && !v.p.findDuplicates {
return v
}
if t.Tok != token.CONST {
return v
}
for _, spec := range t.Specs {
val := spec.(*ast.ValueSpec)
for i, str := range val.Values {
if v.typeInfo != nil && v.p.evalConstExpressions {
typedVal, ok := v.typeInfo.Types[str]
if !ok || !v.isSupportedKind(typedVal.Value.Kind()) {
continue
}
v.addConst(val.Names[i].Name, typedVal.Value.String(), str.Pos())
} else {
lit, ok := str.(*ast.BasicLit)
if !ok || !v.isSupported(lit.Kind) {
continue
}
v.addConst(val.Names[i].Name, lit.Value, val.Names[i].Pos())
}
}
}
// foo := "moo"
case *ast.AssignStmt:
for _, rhs := range t.Rhs {
lit, ok := rhs.(*ast.BasicLit)
if !ok || !v.isSupported(lit.Kind) {
continue
}
v.addString(lit.Value, rhs.(*ast.BasicLit).Pos(), Assignment)
}
// if foo == "moo"
case *ast.BinaryExpr:
if t.Op != token.EQL && t.Op != token.NEQ {
return v
}
var lit *ast.BasicLit
var ok bool
lit, ok = t.X.(*ast.BasicLit)
if ok && v.isSupported(lit.Kind) {
v.addString(lit.Value, lit.Pos(), Binary)
}
lit, ok = t.Y.(*ast.BasicLit)
if ok && v.isSupported(lit.Kind) {
v.addString(lit.Value, lit.Pos(), Binary)
}
// case "foo":
case *ast.CaseClause:
for _, item := range t.List {
lit, ok := item.(*ast.BasicLit)
if ok && v.isSupported(lit.Kind) {
v.addString(lit.Value, lit.Pos(), Case)
}
}
// return "boo"
case *ast.ReturnStmt:
for _, item := range t.Results {
lit, ok := item.(*ast.BasicLit)
if ok && v.isSupported(lit.Kind) {
v.addString(lit.Value, lit.Pos(), Return)
}
}
// fn("http://")
case *ast.CallExpr:
for _, item := range t.Args {
lit, ok := item.(*ast.BasicLit)
if ok && v.isSupported(lit.Kind) {
v.addString(lit.Value, lit.Pos(), Call)
}
}
}
return v
}
// addString adds a string in the map along with its position in the tree.
func (v *treeVisitor) addString(str string, pos token.Pos, typ Type) {
// Early type exclusion check
ok, excluded := v.p.excludeTypes[typ]
if ok && excluded {
return
}
// Drop quotes if any
var unquotedStr string
if strings.HasPrefix(str, `"`) || strings.HasPrefix(str, "`") {
var err error
// Reuse strings from pool if possible to avoid allocations
sb := GetStringBuilder()
defer PutStringBuilder(sb)
unquotedStr, err = strconv.Unquote(str)
if err != nil {
// If unquoting fails, manually strip quotes
// This avoids additional temporary strings
if len(str) >= 2 {
sb.WriteString(str[1 : len(str)-1])
unquotedStr = sb.String()
} else {
unquotedStr = str
}
}
} else {
unquotedStr = str
}
// Early length check
if len(unquotedStr) == 0 || len(unquotedStr) < v.p.minLength {
return
}
// Early regex filtering - pre-compiled for efficiency
if v.ignoreRegex != nil && v.ignoreRegex.MatchString(unquotedStr) {
return
}
// Early number range filtering
if v.p.numberMin != 0 || v.p.numberMax != 0 {
if i, err := strconv.ParseInt(unquotedStr, 0, 0); err == nil {
if (v.p.numberMin != 0 && i < int64(v.p.numberMin)) ||
(v.p.numberMax != 0 && i > int64(v.p.numberMax)) {
return
}
}
}
// Use interned string to reduce memory usage - identical strings share the same memory
internedStr := InternString(unquotedStr)
// Update the count first, this is faster than appending to slices
count := v.p.IncrementStringCount(internedStr)
// Only continue if we're still adding the position to the map
// or if count has reached threshold
if count == 1 || count == v.p.minOccurrences {
// Lock to safely update the shared map
v.p.stringMutex.Lock()
defer v.p.stringMutex.Unlock()
_, exists := v.p.strs[internedStr]
if !exists {
v.p.strs[internedStr] = make([]ExtendedPos, 0, v.p.minOccurrences) // Preallocate with expected size
}
// Create an optimized position record
newPos := ExtendedPos{
packageName: InternString(v.packageName), // Intern the package name to reduce memory
Position: v.fileSet.Position(pos),
}
v.p.strs[internedStr] = append(v.p.strs[internedStr], newPos)
}
}
// addConst adds a const in the map along with its position in the tree.
func (v *treeVisitor) addConst(name string, val string, pos token.Pos) {
// Early filtering using the same criteria as for strings
var unquotedVal string
if strings.HasPrefix(val, `"`) || strings.HasPrefix(val, "`") {
var err error
// Use string builder from pool to reduce allocations
sb := GetStringBuilder()
defer PutStringBuilder(sb)
if unquotedVal, err = strconv.Unquote(val); err != nil {
// If unquoting fails, manually strip quotes without allocations
if len(val) >= 2 {
sb.WriteString(val[1 : len(val)-1])
unquotedVal = sb.String()
} else {
unquotedVal = val
}
}
} else {
unquotedVal = val
}
// Skip constants with values that would be filtered anyway
if len(unquotedVal) < v.p.minLength {
return
}
if v.ignoreRegex != nil && v.ignoreRegex.MatchString(unquotedVal) {
return
}
// Use interned string to reduce memory usage
internedVal := InternString(unquotedVal)
internedName := InternString(name)
internedPkg := InternString(v.packageName)
// Lock to safely update the shared map
v.p.constMutex.Lock()
defer v.p.constMutex.Unlock()
// track this const if this is a new const, or if we are searching for duplicate consts
if _, ok := v.p.consts[internedVal]; !ok || v.p.findDuplicates {
v.p.consts[internedVal] = append(v.p.consts[internedVal], ConstType{
Name: internedName,
packageName: internedPkg,
Position: v.fileSet.Position(pos),
})
}
}
func (v *treeVisitor) isSupported(tk token.Token) bool {
for _, s := range v.p.supportedTokens {
if tk == s {
return true
}
}
return false
}
func (v *treeVisitor) isSupportedKind(kind constant.Kind) bool {
for _, s := range v.p.supportedKinds {
if kind == s {
return true
}
}
return false
}