Skip to content

Commit 71b83c8

Browse files
jgnagyJonathan Gnagy
andauthored
chore: update all dependencies and Ruby to 3.4.10 (#98)
* chore: update all dependencies and Ruby to 3.4.10 Ruby: - .ruby-version: 3.4.4 -> 3.4.10 - Dockerfile: ruby:3.4.4 -> ruby:3.4.10 (both stages) Gemspec constraints widened for major version bumps: - openssl: ~> 3.0 -> >= 3.0, < 5.0 (now resolves to 4.0.2) - sinatra: ~> 3.1 -> >= 3.1, < 5.0 (now resolves to 4.2.1) - sinatra-contrib: ~> 3.1 -> >= 3.1, < 5.0 (now resolves to 4.2.1) - bundler (dev): ~> 2.4 -> >= 2.4, < 5.0 (now resolves to 2.7.2) - byebug (dev): ~> 11 -> >= 11, < 14 (now resolves to 13.0.0) Notable resolved updates: - activesupport/activerecord/activemodel: 8.0.4.1 -> 8.1.3 - rubocop: 1.80.0 -> 1.88.1 - rubocop-rspec: 3.6.0 -> 3.10.2 - rspec: 3.13.1 -> 3.13.2 - itsi: 0.2.19 -> 0.2.27 - solargraph: 0.56.0 -> 0.60.2 - httparty: 0.23.0 -> 0.24.2 - dry-configurable: 1.1.0 -> 1.4.0 - acme-client: 2.0.25 -> 2.0.32 - sqlite3: 2.7.x -> 2.9.5 - trilogy: 2.9.0 -> 2.12.6 - yard: 0.9.37 -> 0.9.44 - jwt: 3.2.0 (via prior dependabot constraint widening) RuboCop 1.88 introduced Style/YodaCondition as a new cop, which flagged two comparisons in lib/bullion.rb. Autocorrected by reversing operand order. db/schema.rb regenerated by ActiveRecord 8.1.3 (minor formatting changes from the newer schema dumper). Verification: - rubocop: 46 files, 0 offenses - rake spec: 65 examples, 0 failures - rake yard: builds successfully * fix: disable Sinatra 4.x host_authorization for API service Sinatra 4.x introduced a new host_authorization setting that blocks requests with unpermitted hosts (defaults to .localhost and .test in development/test, returns 403 'Host not permitted' otherwise). Bullion is an ACME API server that should accept requests regardless of the Host header value. Setting permitted_hosts to [] disables the host check entirely, matching the pre-4.x behavior. This caused 38 test failures in CI because rack-test sends requests with the default host 'example.org', which is not in the permitted hosts list for the test environment. * fix: disable host_authorization for Ping service The Ping service inherits from Sinatra::Application (not Bullion::Service), so it did not inherit the host_authorization fix from the previous commit. This caused 2 remaining test failures in CI. --------- Co-authored-by: Jonathan Gnagy <jgnagy@hermes.home>
1 parent 34bf65a commit 71b83c8

8 files changed

Lines changed: 198 additions & 119 deletions

File tree

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.4.4
1+
3.4.10

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ruby:3.4.4 AS build
1+
FROM ruby:3.4.10 AS build
22

33
ENV RACK_ENV=development
44

@@ -12,7 +12,7 @@ RUN cd /build \
1212

1313
WORKDIR /build
1414

15-
FROM ruby:3.4.4
15+
FROM ruby:3.4.10
1616
LABEL maintainer="Jonathan Gnagy <jonathan.gnagy@gmail.com>"
1717

1818
ENV BULLION_PORT=9292

0 commit comments

Comments
 (0)