Merge pull request #664 from jgraichen/f/rubocop

Author: jgraichen

.rubocop.yml

@@ -1,6 +1,6 @@
 # vim: ft=yaml
 
-require:
+plugins:
   - rubocop-performance
   - rubocop-rails
 

Rakefile

@@ -24,8 +24,8 @@ namespace :i18n do
       # identifiers (e.g. pt_BR), but Redmine needs dashed identifiers
       # (pt-bR). We need convert each top-level key to use dashes.
       #
-      # rubocop: We cannot modify a hash when iterating using
-      # `#each_key`. Therefore, we must us `keys.each` here.
+      # We cannot modify a hash while iterating using `#each_key`.
+      # Therefore, we must us `keys.each` here.
       data.keys.each do |key|
         if key.include?('_')
           data[key.tr('_', '-')] = data.delete(key)
@@ -39,7 +39,7 @@ namespace :i18n do
         # export a `one` key when only an `other` key is needed, such as
         # for Japanese.
         #
-        # This method searches the locale data for any nested dicitonary
+        # This method searches the locale data for any nested dictionary
         # that looks like a pluralized section (contains only `one`,
         # `few`, `other` `many`, `zero` keys). If found, an `one` key
         # will be added with the `other` value.

app/controllers/rdb_taskboard_controller.rb

@@ -19,7 +19,7 @@ def move
     end
 
     # Show dialog if more than one status are available
-    return render 'rdb_dashboard/taskboard/column_dialog' if @statuses.count > 1
+    return render 'rdb_dashboard/taskboard/column_dialog' if @statuses.many?
 
     params[:status] = @statuses.first.id
     update

app/helpers/rdb_dashboard_helper.rb

@@ -19,8 +19,8 @@ def render_rdb_menu(id, title, options = {}, &container)
         concat link
       end
 
-      slim_tag :div, class: "rdb-container #{options[:right] ? 'rdb-container-right' : ''}" do
-        slim_tag :div, class: "rdb-container-wrapper #{options[:icons] ? 'rdb-icons' : ''}" do
+      slim_tag :div, class: "rdb-container #{'rdb-container-right' if options[:right]}" do
+        slim_tag :div, class: "rdb-container-wrapper #{'rdb-icons' if options[:icons]}" do
           if options[:inlet]
             slim_tag(:div, class: 'rdb-container-inlet', &container)
           else
@@ -37,7 +37,7 @@ def render_rdb_menu_list(items = nil, options = {})
       items = nil
     end
 
-    slim_tag :div, class: "rdb-list #{options[:async] ? 'rdb-async' : ''} #{options[:class]}" do
+    slim_tag :div, class: "rdb-list #{'rdb-async' if options[:async]} #{options[:class]}" do
       slim_tag :h3, options[:title] if options[:title]
       slim_tag options[:list_tag] || :ul, class: options[:list_class] do
         if items

app/models/rdb_category_filter.rb

@@ -43,7 +43,7 @@ def update(params)
 
   def title
     return I18n.t(:rdb_filter_category_all) if all?
-    return I18n.t(:rdb_filter_category_multiple) if values.count > 1
+    return I18n.t(:rdb_filter_category_multiple) if values.many?
 
     board.issue_categories.find_by(id: value).try(:name)
   end

app/models/rdb_group.rb

@@ -43,7 +43,7 @@ def visible?
       board.columns.each_value do |column|
         next if !column.visible? || column.compact?
 
-        throw :visible, true if filter(column.issues).count > 0
+        throw :visible, true if filter(column.issues).any?
       end
       false
     end

app/models/rdb_taskboard.rb

@@ -58,7 +58,7 @@ def build
       false
     end
 
-    if done_statuses.count == 1
+    if done_statuses.one?
       status = done_statuses.first
       add_column RdbColumn.new(
         "s#{status.id}",
@@ -67,7 +67,7 @@ def build
         compact: options[:hide_done],
         hide: options[:hide_columns].include?("s#{status.id}"),
       )
-    elsif done_statuses.count > 0
+    elsif done_statuses.any?
       add_column RdbColumn.new(
         'sX',
         :rdb_column_done,

app/models/rdb_tracker_filter.rb

@@ -45,7 +45,7 @@ def update(params)
 
   def title
     return I18n.t(:rdb_filter_tracker_all) if all?
-    return I18n.t(:rdb_filter_tracker_multiple) if values.count > 1
+    return I18n.t(:rdb_filter_tracker_multiple) if values.many?
 
     board.trackers.find(value).name
   end