Merge branch 'main' of https://github.com/opendatahub-io/odh-dashboard into flake-check

Author: jharan1

.claude/rules/pull-requests.md

@@ -0,0 +1,10 @@
+# Pull Request Creation
+
+When creating a pull request targeting `opendatahub-io/odh-dashboard`, you **MUST** use the PR template at `.github/pull_request_template.md` as the PR body structure. Read the template, fill in every section following the HTML comment instructions within it, and include the full checklist. This rule does not apply to PRs targeting other repositories.
+
+## Agent-Specific Guidance
+
+- **Honesty over completeness.** Only check `[x]` checklist items you can substantiate. If you didn't add tests, leave that box unchecked and explain why in the Test Impact section. If you only ran automated checks (lint, type-check), do not check "manually tested."
+- **Post-merge items stay unchecked.** The "After the PR is posted & before it merges" items are human tasks — leave them as `[ ]`.
+- **UI section is conditional.** If the change has no UI impact, omit the "If you have UI changes" checklist items entirely rather than leaving them unchecked.
+- **No bare summaries.** Never skip the template and use a plain paragraph as the PR body. Reviewers expect the full structure.

.coderabbit.yaml

@@ -11,7 +11,6 @@ reviews:
     # Baseline already excludes: vendor, node_modules, bin, __pycache__,
     #   *.sum, *.pb.go, *.generated.go, synced security configs
     - "!package-lock.json"
-    - "!.github/**"
     - "!.tekton/**"
     - "!**/@mf-types/**"
     - "!**/dist/**"

AGENTS.md

@@ -96,6 +96,7 @@ Rules live in `.claude/rules/`. Read the relevant rule file before starting the
 | **Modular Architecture**    | `modular-architecture.md`     | When working on the plugin/extension system or package integration              |
 | **Module Federation**       | `module-federation.md`        | When configuring Module Federation, webpack remotes, or shared dependencies    |
 | **Module Onboarding**       | `module-onboarding.md`        | When creating a new package/module in the monorepo                             |
+| **Pull Requests**           | `pull-requests.md`            | When creating a pull request — must follow `.github/pull_request_template.md`  |
 | **React**                   | `react.md`                    | When writing React components, hooks, or pages                                 |
 | **Security**                | `security.md`                 | When working on auth, secrets, input validation, or K8s API interactions        |
 | **Testing Standards**       | `testing-standards.md`        | When working across multiple test types or choosing a testing strategy          |

frontend/src/app/App.tsx

@@ -125,10 +125,7 @@ const App: React.FC = () => {
               </Alert>
             </StackItem>
             <StackItem>
-              <Button
-                variant="secondary"
-                onClick={() => logout().then(() => window.location.reload())}
-              >
+              <Button variant="secondary" onClick={() => logout()}>
                 Logout
               </Button>
             </StackItem>

frontend/src/app/HeaderTools.tsx

@@ -60,11 +60,7 @@ const HeaderTools: React.FC<Props> = ({ onNotificationsClick, ...devFeatureFlags
 
   const handleLogout = () => {
     setUserMenuOpen(false);
-    logout().then(() => {
-      /* eslint-disable-next-line no-console */
-      console.log('logged out');
-      window.location.reload();
-    });
+    logout();
   };
 
   const userMenuItems = [

frontend/src/app/SessionExpiredModal.tsx

@@ -28,7 +28,7 @@ const SessionExpiredModal: React.FC = () => (
         data-testid="modal-login-button"
         key="confirm"
         variant="primary"
-        onClick={() => logout().then(() => window.location.reload())}
+        onClick={() => logout()}
       >
         Log in
       </Button>

frontend/src/app/appUtils.ts

@@ -1,3 +1,11 @@
-export const logout = (): Promise<unknown> =>
-  /* eslint-disable-next-line no-console */
-  fetch('/oauth2/sign_out').catch((err) => console.error('Error logging out', err));
+import { DEV_MODE } from '#~/utilities/const';
+
+export const logout = (): void => {
+  if (DEV_MODE) {
+    /* eslint-disable-next-line no-console */
+    console.log('you have been logged out in dev mode');
+    window.location.reload();
+    return;
+  }
+  window.location.href = '/oauth2/sign_out';
+};

frontend/src/app/useTimeBasedRefresh.ts

@@ -33,8 +33,8 @@ const useTimeBasedRefresh = (): SetTime => {
     lastDate.setHours(lastDate.getHours() + 1);
     if (lastDate < refreshDateMarker) {
       setNewDateString(refreshDateMarker.toString());
-      console.log('Logging out and refreshing');
-      logout().then(() => window.location.reload());
+      console.log('Logging out and redirecting');
+      logout();
     } else {
       console.error(
         `We should have refreshed but it appears the last time we auto-refreshed was less than an hour ago. '${KEY_NAME}' session storage setting can be cleared for this to refresh again within the hour from the last refresh.`,

frontend/src/components/TypeaheadSelect.tsx

@@ -98,6 +98,8 @@ export interface TypeaheadSelectProps extends Omit<SelectProps, 'toggle' | 'onSe
   dataTestId?: string;
   /** Flag to indicate if showing the description under the toggle */
   previewDescription?: boolean;
+  /** Optional icon rendered inside the text input */
+  inputIcon?: React.ReactNode;
 }
 
 const defaultNoOptionsFoundMessage = (filter: string) => `No results found for "${filter}"`;
@@ -127,6 +129,7 @@ const TypeaheadSelect: React.FunctionComponent<TypeaheadSelectProps> = ({
   isRequired = true,
   previewDescription = true,
   dataTestId,
+  inputIcon,
   ...props
 }: TypeaheadSelectProps) => {
   const [isOpen, setIsOpen] = React.useState(false);
@@ -439,9 +442,11 @@ const TypeaheadSelect: React.FunctionComponent<TypeaheadSelectProps> = ({
               autoComplete="off"
               innerRef={textInputRef}
               placeholder={placeholder}
+              icon={inputIcon}
               {...(activeItemId && { 'aria-activedescendant': activeItemId })}
               role="combobox"
               isExpanded={isOpen}
+              className="pf-v6-u-w-100"
             />
           </FlexItem>
           {selected && selected.selectedLabel && <FlexItem>{selected.selectedLabel}</FlexItem>}

frontend/src/concepts/areas/useIsAreaAvailable.ts

@@ -1,8 +1,8 @@
 import * as React from 'react';
 import { AreaContext } from '#~/concepts/areas/AreaContext';
-import { IsAreaAvailableStatus, SupportedArea } from './types';
+import { IsAreaAvailableStatus, SupportedAreaType } from './types';
 
-const useIsAreaAvailable = (area: SupportedArea): IsAreaAvailableStatus =>
+const useIsAreaAvailable = (area: SupportedAreaType): IsAreaAvailableStatus =>
   React.useContext(AreaContext).areasStatus[area] ?? {
     status: false,
     devFlags: null,