Skip to content

Commit e8c57ab

Browse files
committed
rename to autoEnableRag
1 parent 6f745c9 commit e8c57ab

6 files changed

Lines changed: 26 additions & 26 deletions

File tree

packages/gen-ai/frontend/src/app/Chatbot/components/__tests__/ChatbotSettingsPanel.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,13 +183,13 @@ const createMockSourceManagement = (
183183
): UseSourceManagementReturn => ({
184184
selectedSourceSettings: null,
185185
isSourceSettingsOpen: false,
186-
fileUploadedSignal: false,
186+
autoEnableRag: false,
187187
filesWithSettings: [],
188188
currentFileForSettings: null,
189189
pendingFiles: [],
190190
isUploading: false,
191191
uploadProgress: { current: 0, total: 0 },
192-
setFileUploadedSignal: jest.fn(),
192+
setAutoEnableRag: jest.fn(),
193193
handleSourceDrop: jest.fn(),
194194
removeUploadedSource: jest.fn(),
195195
handleSourceSettingsSubmit: jest.fn(),

packages/gen-ai/frontend/src/app/Chatbot/components/settingsPanelTabs/KnowledgeTabContent.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ const KnowledgeTabContent: React.FunctionComponent<KnowledgeTabContentProps> = (
7676

7777
const [isSelectOpen, setIsSelectOpen] = React.useState(false);
7878

79-
const { fileUploadedSignal, setFileUploadedSignal } = sourceManagement;
79+
const { autoEnableRag, setAutoEnableRag } = sourceManagement;
8080
React.useEffect(() => {
81-
if (fileUploadedSignal) {
81+
if (autoEnableRag) {
8282
updateRagEnabled(configId, true);
83-
setFileUploadedSignal(false);
83+
setAutoEnableRag(false);
8484
}
85-
}, [fileUploadedSignal, setFileUploadedSignal, updateRagEnabled, configId]);
85+
}, [autoEnableRag, setAutoEnableRag, updateRagEnabled, configId]);
8686

8787
const selectedStoreName = React.useMemo(
8888
() => externalVectorStores.find((s) => s.id === selectedVectorStoreId)?.name,

packages/gen-ai/frontend/src/app/Chatbot/components/settingsPanelTabs/__tests__/KnowledgeTabContent.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ describe('KnowledgeTabContent', () => {
6363
): UseSourceManagementReturn => ({
6464
selectedSourceSettings: null,
6565
isSourceSettingsOpen: false,
66-
fileUploadedSignal: false,
66+
autoEnableRag: false,
6767
filesWithSettings: [],
6868
currentFileForSettings: null,
6969
pendingFiles: [],
7070
isUploading: false,
7171
uploadProgress: { current: 0, total: 0 },
72-
setFileUploadedSignal: jest.fn(),
72+
setAutoEnableRag: jest.fn(),
7373
handleSourceDrop: jest.fn(),
7474
removeUploadedSource: jest.fn(),
7575
handleSourceSettingsSubmit: jest.fn(),

packages/gen-ai/frontend/src/app/Chatbot/hooks/__tests__/useSourceManagement.rag-auto-enable.spec.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ describe('useSourceManagement - RAG Auto-Enable', () => {
8888
});
8989
};
9090

91-
it('should signal RAG auto-enable (fileUploadedSignal=true) after a successful file upload', async () => {
91+
it('should signal RAG auto-enable (autoEnableRag=true) after a successful file upload', async () => {
9292
const mockOnFileUploadComplete = jest.fn();
9393
const { result, rerender } = renderHookWithLoadingState(useSourceManagement, {
9494
onShowSuccessAlert: mockOnShowSuccessAlert,
@@ -97,11 +97,11 @@ describe('useSourceManagement - RAG Auto-Enable', () => {
9797
});
9898

9999
simulateLoadingComplete(rerender);
100-
expect(result.current.fileUploadedSignal).toBe(false);
100+
expect(result.current.autoEnableRag).toBe(false);
101101

102102
await uploadFileFlow(result);
103103

104-
expect(result.current.fileUploadedSignal).toBe(true);
104+
expect(result.current.autoEnableRag).toBe(true);
105105
expect(mockOnShowSuccessAlert).toHaveBeenCalled();
106106
});
107107

@@ -116,15 +116,15 @@ describe('useSourceManagement - RAG Auto-Enable', () => {
116116
});
117117

118118
simulateLoadingComplete(rerender, [existingFile]);
119-
expect(result.current.fileUploadedSignal).toBe(false);
119+
expect(result.current.autoEnableRag).toBe(false);
120120

121121
await uploadFileFlow(result);
122122

123-
expect(result.current.fileUploadedSignal).toBe(true);
123+
expect(result.current.autoEnableRag).toBe(true);
124124
expect(mockOnShowSuccessAlert).toHaveBeenCalled();
125125
});
126126

127-
it('should signal RAG auto-enable again after fileUploadedSignal is reset', async () => {
127+
it('should signal RAG auto-enable again after autoEnableRag is reset', async () => {
128128
const mockOnFileUploadComplete = jest.fn();
129129
const { result, rerender } = renderHookWithLoadingState(useSourceManagement, {
130130
onShowSuccessAlert: mockOnShowSuccessAlert,
@@ -135,12 +135,12 @@ describe('useSourceManagement - RAG Auto-Enable', () => {
135135
simulateLoadingComplete(rerender);
136136

137137
await uploadFileFlow(result);
138-
expect(result.current.fileUploadedSignal).toBe(true);
138+
expect(result.current.autoEnableRag).toBe(true);
139139

140140
act(() => {
141-
result.current.setFileUploadedSignal(false);
141+
result.current.setAutoEnableRag(false);
142142
});
143-
expect(result.current.fileUploadedSignal).toBe(false);
143+
expect(result.current.autoEnableRag).toBe(false);
144144

145145
const mockFile2 = new File(['test content 2'], 'test2.txt', { type: 'text/plain' });
146146
await act(async () => {
@@ -152,7 +152,7 @@ describe('useSourceManagement - RAG Auto-Enable', () => {
152152
await result.current.handleSourceSettingsSubmit(mockSourceSettings);
153153
});
154154

155-
expect(result.current.fileUploadedSignal).toBe(true);
155+
expect(result.current.autoEnableRag).toBe(true);
156156
});
157157

158158
it('should not signal RAG auto-enable if all uploads fail', async () => {
@@ -170,7 +170,7 @@ describe('useSourceManagement - RAG Auto-Enable', () => {
170170

171171
await uploadFileFlow(result);
172172

173-
expect(result.current.fileUploadedSignal).toBe(false);
173+
expect(result.current.autoEnableRag).toBe(false);
174174
expect(mockOnShowErrorAlert).toHaveBeenCalled();
175175
});
176176
});

packages/gen-ai/frontend/src/app/Chatbot/hooks/__tests__/useSourceManagement.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ describe('useSourceManagement', () => {
8484
expect(result.current.filesWithSettings).toEqual([]);
8585
expect(result.current.selectedSourceSettings).toBeNull();
8686
expect(result.current.isSourceSettingsOpen).toBe(false);
87-
expect(result.current.fileUploadedSignal).toBe(false);
87+
expect(result.current.autoEnableRag).toBe(false);
8888
expect(result.current.currentFileForSettings).toBeNull();
8989
});
9090
});

packages/gen-ai/frontend/src/app/Chatbot/hooks/useSourceManagement.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ export interface FileWithSettings {
2121
export interface UseSourceManagementReturn {
2222
selectedSourceSettings: ChatbotSourceSettings | null;
2323
isSourceSettingsOpen: boolean;
24-
fileUploadedSignal: boolean;
24+
autoEnableRag: boolean;
2525
filesWithSettings: FileWithSettings[];
2626
currentFileForSettings: File | null;
2727
pendingFiles: File[];
2828
isUploading: boolean;
2929
uploadProgress: { current: number; total: number };
30-
setFileUploadedSignal: (value: boolean) => void;
30+
setAutoEnableRag: (value: boolean) => void;
3131
handleSourceDrop: (event: DropEvent, source: File[]) => Promise<void>;
3232
removeUploadedSource: (fileName: string) => void;
3333
handleSourceSettingsSubmit: (settings: ChatbotSourceSettings | null) => Promise<void>;
@@ -59,7 +59,7 @@ const useSourceManagement = ({
5959
const { MAX_FILE_SIZE, MAX_FILES_IN_VECTOR_STORE } = FILE_UPLOAD_CONFIG;
6060
const [selectedSourceSettings, setSelectedSourceSettings] =
6161
React.useState<ChatbotSourceSettings | null>(null);
62-
const [fileUploadedSignal, setFileUploadedSignal] = React.useState(false);
62+
const [autoEnableRag, setAutoEnableRag] = React.useState(false);
6363
const [isSourceSettingsOpen, setIsSourceSettingsOpen] = React.useState(false);
6464
const [filesWithSettings, setFilesWithSettings] = React.useState<FileWithSettings[]>([]);
6565
const [currentFileForSettings, setCurrentFileForSettings] = React.useState<File | null>(null);
@@ -255,7 +255,7 @@ const useSourceManagement = ({
255255

256256
// Signal RAG auto-enable on any successful upload
257257
if (successCount > 0) {
258-
setFileUploadedSignal(true);
258+
setAutoEnableRag(true);
259259
}
260260

261261
// Refresh the uploaded files list
@@ -317,13 +317,13 @@ const useSourceManagement = ({
317317
return {
318318
selectedSourceSettings,
319319
isSourceSettingsOpen,
320-
fileUploadedSignal,
320+
autoEnableRag,
321321
filesWithSettings,
322322
currentFileForSettings,
323323
pendingFiles,
324324
isUploading,
325325
uploadProgress,
326-
setFileUploadedSignal,
326+
setAutoEnableRag,
327327
handleSourceDrop,
328328
removeUploadedSource,
329329
handleSourceSettingsSubmit,

0 commit comments

Comments
 (0)