Sonar recommendations (#32057)

Author: qmonmert

cli/commands.ts

@@ -96,7 +96,7 @@ const defaultCommands = {
     alias: 'import-jdl',
     desc: `Create entities from the JDL file/URL/content passed in argument.
     Use the '--interactive' flag to generate multiple applications in series.`,
-    help: `
+    help: String.raw`
     Arguments:
     jdlFiles # The JDL file names or URL Type: String[] Required: true if --inline is not set
 
@@ -106,7 +106,7 @@ const defaultCommands = {
     jhipster jdl https://gist.githubusercontent.com/user/path/app.jdl
     jhipster jdl jdl-name-from-jdl-samples-repo.jdl (just pass any file name from https://github.com/jhipster/jdl-samples)
     jhipster jdl --inline "application { config { baseName jhapp, testFrameworks [cypress] }}"
-    jhipster jdl --inline \\
+    jhipster jdl --inline \
         "application {
             config {
                 baseName jhapp,

cli/jhipster-command.ts

@@ -180,9 +180,9 @@ export default class JHipsterCommand extends Command {
     }
     cmdString = `${cmdString}${longOption}`;
     if (optionDefinition.type === Array) {
-      cmdString = optionDefinition.required !== false ? `${cmdString} <value...>` : `${cmdString} [value...]`;
+      cmdString = optionDefinition.required === false ? `${cmdString} [value...]` : `${cmdString} <value...>`;
     } else if (optionDefinition.type && optionDefinition.type !== Boolean) {
-      cmdString = optionDefinition.required !== false ? `${cmdString} <value>` : `${cmdString} [value]`;
+      cmdString = optionDefinition.required === false ? `${cmdString} [value]` : `${cmdString} <value>`;
     }
     // Passing default to `commander` (`.default(optionDefinition.default)`), will set at options passed to initial generator, so it's used in entire generation process.
     // We want default value to be set on jhipster options parsing so ignore default at commander.

cli/program.ts

@@ -252,7 +252,7 @@ export const buildCommands = ({
     program
       .command(cmdName, '', { isDefault: cmdName === defaultCommand, hidden: Boolean(removed) })
       .description(desc + (blueprint ? chalk.yellow(` (blueprint: ${blueprint})`) : ''))
-      .addCommandArguments(argument!)
+      .addCommandArguments(argument)
       .addCommandOptions(commandOptions)
       .addHelpText('after', commandHelp!)
       .addAlias(alias!)

generators/angular/generator.ts

@@ -278,10 +278,10 @@ export default class AngularGenerator extends AngularApplicationGenerator {
             let returnValue: string | undefined;
             if (fieldTsDefaultValue !== undefined || defaultValue !== undefined) {
               let fieldDefaultValue;
-              if (fieldTsDefaultValue !== undefined) {
-                fieldDefaultValue = fieldTsDefaultValue;
-              } else {
+              if (fieldTsDefaultValue === undefined) {
                 fieldDefaultValue = defaultValue;
+              } else {
+                fieldDefaultValue = fieldTsDefaultValue;
               }
 
               fieldDefaultValue = String(fieldDefaultValue).replace(/'/g, String.raw`\'`);

generators/app/generator.ts

@@ -76,7 +76,7 @@ export default class AppGenerator extends BaseApplicationGenerator<CommonEntity,
         if (!this.options.reproducible) {
           this.config.defaults({
             baseName: getDefaultAppName({ cwd: this.destinationPath() }),
-            creationTimestamp: new Date().getTime(),
+            creationTimestamp: Date.now(),
           });
         }
       },

generators/app/generators/bootstrap/generator.ts

@@ -59,9 +59,7 @@ export default class BootstrapApplicationGenerator extends BaseApplicationGenera
   get configuringEachEntity() {
     return this.asConfiguringEachEntityTaskGroup({
       configureFields({ entityName, entityConfig }) {
-        if (entityConfig.name === undefined) {
-          entityConfig.name = entityName;
-        }
+        entityConfig.name ??= entityName;
 
         entityConfig.fields!.forEach((field: CommonField) => {
           const { fieldName, fieldType, fieldValidateRules } = field;

generators/base/support/timestamp.ts

@@ -71,7 +71,7 @@ export function parseChangelog(changelogDate: string): Date {
   const day = zeroFallback(changelogDate.substring(6, 8), '01');
   const formattedDate = `${year}-${month}-${day}T${changelogDate.substring(8, 10)}:${changelogDate.substring(10, 12)}:${changelogDate.substring(12, 14)}+00:00`;
   const parsedTimestamp = Date.parse(formattedDate);
-  if (isNaN(parsedTimestamp)) {
+  if (Number.isNaN(parsedTimestamp)) {
     throw new Error(`changelogDate ${changelogDate} is not a valid date.`);
   }
   return new Date(parsedTimestamp);
@@ -89,7 +89,7 @@ export const parseCreationTimestamp = (creationTimestampOption: string): number
     if (!creationTimestamp) {
       return undefined;
     }
-    if (creationTimestamp > new Date().getTime()) {
+    if (creationTimestamp > Date.now()) {
       throw new Error(`Creation timestamp should not be in the future: ${creationTimestampOption}.`);
     }
   }