Simplify Array/Set (#31601)

Author: qmonmert

generators/base-application/generator.ts

@@ -273,7 +273,7 @@ export default class BaseApplicationGenerator<
     const configDir = this.getEntitiesConfigPath();
 
     const entities: { name: string; definition: Entity }[] = [];
-    for (const entityName of [...new Set(((this.jhipsterConfig.entities as string[]) || []).concat(getEntitiesFromDir(configDir)))]) {
+    for (const entityName of new Set(((this.jhipsterConfig.entities as string[]) || []).concat(getEntitiesFromDir(configDir)))) {
       const definition: Entity = this.getEntityConfig(entityName)?.getAll() as unknown as Entity;
       if (definition) {
         entities.push({ name: entityName, definition });

generators/base-application/generators/bootstrap/generator.ts

@@ -423,7 +423,7 @@ export default class BootstrapBaseApplicationGenerator extends BaseApplicationGe
           relatedEntities.add(entity);
           return entity.relationships
             ?.filter(rel => rel.relationshipRequired || rel.id)
-            .some(rel => detectCyclicRequiredRelationship(rel.otherEntity, new Set([...relatedEntities])));
+            .some(rel => detectCyclicRequiredRelationship(rel.otherEntity, new Set(relatedEntities)));
         };
         entity.hasCyclicRequiredRelationship = detectCyclicRequiredRelationship(entity, new Set());
       },

generators/javascript-simple-application/generators/prettier/generator.ts

@@ -105,7 +105,7 @@ export default class PrettierGenerator extends JavascriptSimpleApplicationGenera
             },
           });
         } else if (clientFrameworkBuiltIn || clientFrameworkNo) {
-          const prettierFolders = [...new Set([...application.prettierFolders])];
+          const prettierFolders = [...new Set(application.prettierFolders)];
           this.packageJson.merge({
             scripts: {
               'prettier:check': `prettier --check "{${prettierFolders.join(',')}}*.{${prettierExtensions.join(',')}}"`,

generators/jdl/internal/application.ts

@@ -38,7 +38,7 @@ export const customizeForMicroservices = (applicationsWithEntities: Record<strin
       }
     }
 
-    const relatedBaseNames = [...microfrontends.map(mf => mf.baseName)];
+    const relatedBaseNames = microfrontends.map(mf => mf.baseName);
     gateway.entities
       .map(entity => entity.microserviceName)
       .filter(Boolean)