tests: xfail NITRC search tests blocked by AWS WAF (pyxnat#210)

NITRC now blocks POST /ir/data/search with an AWS WAF “challenge” (status 202, empty body),
causing pyxnat search-based tests (Search.where / search_experiments) to fail for
reasons outside pyxnat/XNAT control. Mark affected tests as xfail.

Author: jhuguetn

pyxnat/tests/__init__.py

@@ -2,6 +2,8 @@
 import pytest
 import os
 
+REASON_NITRC_WAF = "NITRC blocks POST /data/search via AWS WAF (firewall)"
+
 
 def skip_if_no_network(func=None):
     """Skip test completely in NONETWORK settings

pyxnat/tests/array_test.py

@@ -1,6 +1,7 @@
 import unittest
+import pytest
 from pyxnat import Interface
-from pyxnat.tests import skip_if_no_network
+from pyxnat.tests import skip_if_no_network, REASON_NITRC_WAF
 import logging as log
 log.basicConfig(level=log.INFO)
 
@@ -59,6 +60,9 @@ def test_array_mrscans(self):
 
     @skip_if_no_network
     def test_search_experiments(self):
+        if "nitrc.org" in self._intf._server:
+            pytest.xfail(REASON_NITRC_WAF)
+
         et = 'xnat:subjectData'
         e = self._intf.array.search_experiments(project_id='ixi',
                                                 experiment_type=et)

pyxnat/tests/interfaces_test.py

@@ -2,7 +2,8 @@
 import os.path as op
 import tempfile 
 from pyxnat import Interface
-from pyxnat.tests import skip_if_no_network
+from pyxnat.tests import skip_if_no_network, REASON_NITRC_WAF
+import pytest
 
 fp = op.abspath('.central.cfg')
 central = Interface(config=fp)
@@ -28,6 +29,9 @@ def test_nested_path_listing():
 
 @skip_if_no_network
 def test_search_access():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     constraints = [('xnat:subjectData/PROJECT', '=', 'ixi'),
                    'AND']
 

pyxnat/tests/search_test.py

@@ -2,6 +2,8 @@
 from pyxnat import Interface
 from pyxnat import jsonutil
 import os.path as op
+import pytest
+from pyxnat.tests import REASON_NITRC_WAF
 
 fp = op.abspath('.central.cfg')
 central = Interface(config=fp)
@@ -21,6 +23,9 @@ def test_datafields():
 
 
 def test_fieldvalues():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     assert len(central.inspect.field_values('xnat:subjectData/SUBJECT_ID')
                ) != 0
 
@@ -48,6 +53,9 @@ def test_inspect_resources():
 
 
 def test_search():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     results = central.select(
         'xnat:mrSessionData',
         central.inspect.datatypes('xnat:mrSessionData')
@@ -58,6 +66,9 @@ def test_search():
 
 
 def test_save_search():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     central.manage.search.save(
         search_name, 'xnat:mrSessionData',
         central.inspect.datatypes('xnat:mrSessionData'),
@@ -68,16 +79,25 @@ def test_save_search():
 
 
 def test_get_search():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     results = central.manage.search.get(search_name)
     assert isinstance(results, jsonutil.JsonTable)
 
 
 def test_delete_search():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     central.manage.search.delete(search_name)
     assert search_name not in central.manage.search.saved()
 
 
 def test_save_search_template():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     central.manage.search.save_template(
         search_template_name, 'xnat:mrSessionData',
         central.inspect.datatypes('xnat:mrSessionData'),
@@ -89,6 +109,9 @@ def test_save_search_template():
 
 
 def test_delete_search_template():
+    if "nitrc.org" in central._server:
+        pytest.xfail(REASON_NITRC_WAF)
+
     central.manage.search.delete_template(search_template_name)
     assert search_template_name not in \
         central.manage.search.saved_templates()