Fix APIError.Empty() logic

jianyuan · jianyuan · commit e5aea9b700a1 · 2022-05-26T21:03:52.000+01:00
diff --git a/sentry/errors.go b/sentry/errors.go
@@ -22,6 +22,7 @@ func (e *APIError) UnmarshalJSON(b []byte) error {
 	}
 	return nil
 }
+
 func (e *APIError) MarshalJSON() ([]byte, error) {
 	return json.Marshal(e.f)
 }
@@ -41,7 +42,9 @@ func (e APIError) Error() string {
 }
 
 // Empty returns true if empty.
-func (e APIError) Empty() bool { return e.f != nil }
+func (e APIError) Empty() bool {
+	return e.f == nil
+}
 
 func relevantError(httpError error, apiError APIError) error {
 	if httpError != nil {

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ func (e *APIError) UnmarshalJSON(b []byte) error {`
`22`	`22`	`}`
`23`	`23`	`return nil`
`24`	`24`	`}`
	`25`	`+`
`25`	`26`	`func (e *APIError) MarshalJSON() ([]byte, error) {`
`26`	`27`	`return json.Marshal(e.f)`
`27`	`28`	`}`
`@@ -41,7 +42,9 @@ func (e APIError) Error() string {`
`41`	`42`	`}`
`42`	`43`
`43`	`44`	`// Empty returns true if empty.`
`44`		`-func (e APIError) Empty() bool { return e.f != nil }`
	`45`	`+func (e APIError) Empty() bool {`
	`46`	`+ return e.f == nil`
	`47`	`+}`
`45`	`48`
`46`	`49`	`func relevantError(httpError error, apiError APIError) error {`
`47`	`50`	`if httpError != nil {`