fix: conditions nil check

Author: jianyuan

internal/provider/model_issue_alert.go

@@ -8,6 +8,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 	"github.com/jianyuan/go-utils/must"
+	"github.com/jianyuan/go-utils/ptr"
 	"github.com/jianyuan/go-utils/sliceutils"
 	"github.com/jianyuan/terraform-provider-sentry/internal/apiclient"
 	"github.com/jianyuan/terraform-provider-sentry/internal/sentrytypes"
@@ -258,19 +259,19 @@ func (m *IssueAlertConditionModel) FromApi(ctx context.Context, condition apicli
 }
 
 type IssueAlertModel struct {
-	Id           types.String               `tfsdk:"id"`
-	Organization types.String               `tfsdk:"organization"`
-	Project      types.String               `tfsdk:"project"`
-	Name         types.String               `tfsdk:"name"`
-	Conditions   sentrytypes.LossyJson      `tfsdk:"conditions"`
-	Filters      sentrytypes.LossyJson      `tfsdk:"filters"`
-	Actions      sentrytypes.LossyJson      `tfsdk:"actions"`
-	ActionMatch  types.String               `tfsdk:"action_match"`
-	FilterMatch  types.String               `tfsdk:"filter_match"`
-	Frequency    types.Int64                `tfsdk:"frequency"`
-	Environment  types.String               `tfsdk:"environment"`
-	Owner        types.String               `tfsdk:"owner"`
-	ConditionsV2 []IssueAlertConditionModel `tfsdk:"conditions_v2"`
+	Id           types.String                `tfsdk:"id"`
+	Organization types.String                `tfsdk:"organization"`
+	Project      types.String                `tfsdk:"project"`
+	Name         types.String                `tfsdk:"name"`
+	Conditions   sentrytypes.LossyJson       `tfsdk:"conditions"`
+	Filters      sentrytypes.LossyJson       `tfsdk:"filters"`
+	Actions      sentrytypes.LossyJson       `tfsdk:"actions"`
+	ActionMatch  types.String                `tfsdk:"action_match"`
+	FilterMatch  types.String                `tfsdk:"filter_match"`
+	Frequency    types.Int64                 `tfsdk:"frequency"`
+	Environment  types.String                `tfsdk:"environment"`
+	Owner        types.String                `tfsdk:"owner"`
+	ConditionsV2 *[]IssueAlertConditionModel `tfsdk:"conditions_v2"`
 }
 
 func (m *IssueAlertModel) Fill(ctx context.Context, alert apiclient.ProjectRule) (diags diag.Diagnostics) {
@@ -300,11 +301,11 @@ func (m *IssueAlertModel) Fill(ctx context.Context, alert apiclient.ProjectRule)
 		}
 	} else {
 		m.Conditions = sentrytypes.NewLossyJsonNull()
-		m.ConditionsV2 = sliceutils.Map(func(condition apiclient.ProjectRuleCondition) IssueAlertConditionModel {
+		m.ConditionsV2 = ptr.Ptr(sliceutils.Map(func(condition apiclient.ProjectRuleCondition) IssueAlertConditionModel {
 			var conditionModel IssueAlertConditionModel
 			diags.Append(conditionModel.FromApi(ctx, condition)...)
 			return conditionModel
-		}, alert.Conditions)
+		}, alert.Conditions))
 
 		if diags.HasError() {
 			return

internal/provider/resource_issue_alert.go

@@ -95,7 +95,6 @@ Please note the following changes since v0.12.0:
 				MarkdownDescription: "**Deprecated** in favor of `condition`. A list of triggers that determine when the rule fires. In JSON string format.",
 				DeprecationMessage:  "Use `condition` instead.",
 				Optional:            true,
-				Computed:            true,
 				CustomType: sentrytypes.LossyJsonType{
 					IgnoreKeys: []string{"name"},
 				},
@@ -255,10 +254,12 @@ func (r *IssueAlertResource) Create(ctx context.Context, req resource.CreateRequ
 
 	if !data.Conditions.IsNull() {
 		resp.Diagnostics.Append(data.Conditions.Unmarshal(&body.Conditions)...)
-	} else {
+	} else if data.ConditionsV2 != nil {
 		body.Conditions = sliceutils.Map(func(item IssueAlertConditionModel) apiclient.ProjectRuleCondition {
 			return item.ToApi()
-		}, data.ConditionsV2)
+		}, *data.ConditionsV2)
+	} else {
+		panic("provider error: conditions is required")
 	}
 
 	if !data.Filters.IsNull() {
@@ -353,10 +354,12 @@ func (r *IssueAlertResource) Update(ctx context.Context, req resource.UpdateRequ
 
 	if !data.Conditions.IsNull() {
 		resp.Diagnostics.Append(data.Conditions.Unmarshal(&body.Conditions)...)
-	} else {
+	} else if data.ConditionsV2 != nil {
 		body.Conditions = sliceutils.Map(func(item IssueAlertConditionModel) apiclient.ProjectRuleCondition {
 			return item.ToApi()
-		}, data.ConditionsV2)
+		}, *data.ConditionsV2)
+	} else {
+		panic("provider error: conditions is required")
 	}
 
 	if !data.Filters.IsNull() {

internal/provider/resource_issue_alert_test.go

@@ -234,7 +234,7 @@ func TestAccIssueAlertResource_jsonValues(t *testing.T) {
 	rn := "sentry_issue_alert.test"
 	team := acctest.RandomWithPrefix("tf-team")
 	project := acctest.RandomWithPrefix("tf-project")
-	alert := acctest.RandomWithPrefix("tf-issue-alert-with-a-very-looooong-name-greater-than-64-characters")
+	alert := acctest.RandomWithPrefix("tf-issue-alert")
 	var alertId string
 
 	check := func(alert string) resource.TestCheckFunc {
@@ -253,15 +253,14 @@ func TestAccIssueAlertResource_jsonValues(t *testing.T) {
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("id"), knownvalue.NotNull()),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("organization"), knownvalue.StringExact(acctest.TestOrganization)),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("project"), knownvalue.StringExact(project)),
-		statecheck.ExpectKnownValue(rn, tfjsonpath.New("name"), knownvalue.StringExact(alert)),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("action_match"), knownvalue.StringExact("any")),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("filter_match"), knownvalue.StringExact("any")),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("frequency"), knownvalue.Int64Exact(30)),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("environment"), knownvalue.Null()),
 		statecheck.ExpectKnownValue(rn, tfjsonpath.New("owner"), knownvalue.Null()),
-		statecheck.ExpectKnownValue(rn, tfjsonpath.New("conditions"), knownvalue.StringExact("[]")),
-		statecheck.ExpectKnownValue(rn, tfjsonpath.New("filters"), knownvalue.StringExact("[]")),
-		statecheck.ExpectKnownValue(rn, tfjsonpath.New("actions"), knownvalue.StringExact("[]")),
+		statecheck.ExpectKnownValue(rn, tfjsonpath.New("conditions"), knownvalue.NotNull()),
+		statecheck.ExpectKnownValue(rn, tfjsonpath.New("filters"), knownvalue.NotNull()),
+		statecheck.ExpectKnownValue(rn, tfjsonpath.New("actions"), knownvalue.NotNull()),
 	}
 
 	resource.Test(t, resource.TestCase{