[TestCase] azurerm_log_analytics_storage_insights - Mark storage_account_id as ForceNew (hashicorp#30344)

Author: neil-yechenwei

internal/services/loganalytics/log_analytics_storage_insights_resource.go

@@ -16,6 +16,7 @@ import (
 	"github.com/hashicorp/terraform-provider-azurerm/helpers/tf"
 	azValidate "github.com/hashicorp/terraform-provider-azurerm/helpers/validate"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
+	"github.com/hashicorp/terraform-provider-azurerm/internal/features"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics/validate"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/tf/validation"
@@ -191,6 +192,7 @@ func resourceLogAnalyticsStorageInsightsSchema() map[string]*pluginsdk.Schema {
 		"storage_account_id": {
 			Type:         pluginsdk.TypeString,
 			Required:     true,
+			ForceNew:     features.FivePointOh(),
 			ValidateFunc: commonids.ValidateStorageAccountID,
 		},
 

internal/services/loganalytics/log_analytics_storage_insights_resource_test.go

@@ -100,7 +100,7 @@ func TestAccLogAnalyticsStorageInsights_updateStorageAccount(t *testing.T) {
 		},
 		data.ImportStep("storage_account_key"),
 		{
-			Config: r.updateStorageAccount(data),
+			Config: r.updateStorageAccountKey(data),
 			Check: acceptance.ComposeTestCheckFunc(
 				check.That(data.ResourceName).ExistsInAzure(r),
 			),
@@ -201,19 +201,10 @@ resource "azurerm_log_analytics_storage_insights" "test" {
 `, r.template(data), data.RandomInteger)
 }
 
-func (r LogAnalyticsStorageInsightsResource) updateStorageAccount(data acceptance.TestData) string {
+func (r LogAnalyticsStorageInsightsResource) updateStorageAccountKey(data acceptance.TestData) string {
 	return fmt.Sprintf(`
 %s
 
-resource "azurerm_storage_account" "test2" {
-  name                = "acctestsads%s"
-  resource_group_name = azurerm_resource_group.test.name
-
-  location                 = azurerm_resource_group.test.location
-  account_tier             = "Standard"
-  account_replication_type = "LRS"
-}
-
 resource "azurerm_log_analytics_storage_insights" "test" {
   name                = "acctest-la-%d"
   resource_group_name = azurerm_resource_group.test.name
@@ -222,8 +213,8 @@ resource "azurerm_log_analytics_storage_insights" "test" {
   blob_container_names = ["wad-iis-logfiles"]
   table_names          = ["WADWindowsEventLogsTable", "LinuxSyslogVer2v0"]
 
-  storage_account_id  = azurerm_storage_account.test2.id
-  storage_account_key = azurerm_storage_account.test2.primary_access_key
+  storage_account_id  = azurerm_storage_account.test.id
+  storage_account_key = azurerm_storage_account.test.secondary_access_key
 }
-`, r.template(data), data.RandomStringOfLength(6), data.RandomInteger)
+`, r.template(data), data.RandomInteger)
 }

website/docs/5.0-upgrade-guide.html.markdown

@@ -339,6 +339,10 @@ Please follow the format in the example below for listing breaking changes in re
 
 * The deprecated `workspace_resource_id` property has been removed and superseded by the `workspace_id` property.
 
+### `azurerm_log_analytics_storage_insights`
+
+* The `storage_account_id` property is marked as `ForceNew`.
+
 ### `azurerm_log_analytics_workspace`
 
 * The deprecated `local_authentication_disabled` property has been removed in favour of the `local_authentication_enabled` property.