update global exception handler

Author: jicking

JixMinApi/Common/GlobalExceptionHandler.cs

@@ -0,0 +1,48 @@
+using System.Diagnostics;
+using Microsoft.AspNetCore.Diagnostics;
+using Microsoft.AspNetCore.Mvc;
+
+namespace JixMinApi.Shared;
+
+
+public class GlobalExceptionHandler(ILogger<GlobalExceptionHandler> logger) : IExceptionHandler
+{
+    private readonly ILogger<GlobalExceptionHandler> logger = logger;
+
+    public async ValueTask<bool> TryHandleAsync(
+        HttpContext httpContext,
+        Exception exception,
+        CancellationToken cancellationToken)
+    {
+        var traceId = Activity.Current?.Id ?? httpContext.TraceIdentifier;
+
+        logger.LogError(
+            exception,
+            "Could not process a request on machine {MachineName}. TraceId: {TraceId}",
+            Environment.MachineName,
+            traceId
+        );
+
+        var (statusCode, title) = MapException(exception);
+
+        await Results.Problem(
+            title: title,
+            statusCode: statusCode,
+            extensions: new Dictionary<string, object?>
+            {
+                {"traceId",  traceId}
+            }
+        ).ExecuteAsync(httpContext);
+
+        return true;
+    }
+
+    private static (int StatusCode, string Title) MapException(Exception exception)
+    {
+        return exception switch
+        {
+            ArgumentOutOfRangeException => (StatusCodes.Status400BadRequest, exception.Message),
+            _ => (StatusCodes.Status500InternalServerError, "Server error")
+        };
+    }
+}

JixMinApi/Features/Todo/TodoEndpoints.cs

@@ -2,6 +2,7 @@
 using JixMinApi.Features.Todo.Queries;
 using MediatR;
 using Microsoft.AspNetCore.Http.HttpResults;
+using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.OpenApi.Models;
 using System.Net.Mime;
@@ -40,12 +41,15 @@ public static void UseTodoEndpoints(this WebApplication app)
         group.MapGet("/{id}", GetTodoByIdAsync)
             .Produces<TodoDto>(StatusCodes.Status200OK)
             .Produces<HttpValidationProblemDetails>(StatusCodes.Status400BadRequest)
-            .Produces(StatusCodes.Status404NotFound);
+            .Produces(StatusCodes.Status404NotFound)
+            .Produces<ProblemDetails>(StatusCodes.Status500InternalServerError);
+
 
         group.MapPost("/", CreateTodoAsync)
             .Accepts<CreateTodoDto>(MediaTypeNames.Application.Json)
             .Produces<TodoDto>(StatusCodes.Status201Created)
-            .Produces<HttpValidationProblemDetails>(StatusCodes.Status400BadRequest);
+            .Produces<HttpValidationProblemDetails>(StatusCodes.Status400BadRequest)
+            .Produces<ProblemDetails>(StatusCodes.Status500InternalServerError);
 
         //group.MapDelete("/{id}", GetAllTodosAsync)
         //    .Produces(StatusCodes.Status204NoContent)

JixMinApi/Program.cs

@@ -48,18 +48,18 @@
     builder.Services.AddHealthChecks();
 
     var app = builder.Build();
+    app.UseHttpsRedirection();
 
-    // Configure the HTTP request pipeline.
-    if (app.Environment.IsDevelopment())
+    if (!app.Environment.IsDevelopment())
     {
-        app.UseSwagger();
-        app.UseSwaggerUI();
+        app.UseStatusCodePages();
+        app.UseExceptionHandler();
     }
 
-    if (!app.Environment.IsDevelopment())
+    if (app.Environment.IsDevelopment())
     {
-        app.UseHttpsRedirection();
-        app.UseExceptionHandler();
+        app.UseSwagger();
+        app.UseSwaggerUI();
     }
 
     app.UseSerilogRequestLogging();