@jimschubert

redirect.js has to be loaded last, that's how the extension works.

I think it is possible to front-load just a small part of NewTab-Redirect's redirect.js with minimal changes to the rest of the extension:

First, conditionally redirect in the <head> based on url/localStorage. (This doesn't seem to require angular at all.)
Then if not redirected, the angular portion of redirect.js can load. (Show/render the extension page.)

Right now NewTab-Redirect is using this order:

Initialize angular (Show/render the extension page.)
Conditionally redirect based on URL/localstorage.

So this is the only part of redirect.js that would be loaded in the <head>: (The conditional redirect)

NewTab-Redirect/js/redirect.js

Lines 5 to 10 in 422858b

    
           chrome.storage.local.get(["url", "tab.selected", "always-tab-update"], function (items) { 
        
               var url = items.url; 
        
               if (url) { 
        
                   url = (0 !== url.indexOf("about:") && 0 !== url.indexOf("data:") && -1 === url.indexOf("://")) ? ("http://" + url) : url; 
        
                   if (/^http[s]?:/i.test(url) && items["always-tab-update"] !== true) { 
        
                       document.location.href = url;

Now, I am not sure if all the checks can be done from the head (Is chrome.storage.local.get available?) And perhaps redirecting from the head would violate some Chrome store rule?

So even if the JS logic is left the same, I think updating the CSS to honor the prefers-color-scheme would mitigate the magnitude of the white flash. Because CSS is being loaded and rendered:

NewTab-Redirect/main.html

Lines 8 to 9 in 422858b

    
           <link rel="stylesheet" href="css/font-awesome.min.css" type="text/css"> 
        
           <link rel="stylesheet" href="css/common.css" type="text/css">

	chrome.storage.local.get(["url", "tab.selected", "always-tab-update"], function (items) {
	var url = items.url;
	if (url) {
	url = (0 !== url.indexOf("about:") && 0 !== url.indexOf("data:") && -1 === url.indexOf("://")) ? ("http://" + url) : url;
	if (/^http[s]?:/i.test(url) && items["always-tab-update"] !== true) {
	document.location.href = url;

	<link rel="stylesheet" href="css/font-awesome.min.css" type="text/css">
	<link rel="stylesheet" href="css/common.css" type="text/css">

Uh oh!

White flash problem #228

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions