feat: add Go language support with golangci-lint configuration and update Makefile for linting

Author: jingyi-zhao-01

.vscode/extensions.json

@@ -0,0 +1,5 @@
+{
+  "recommendations": [
+    "golang.Go"
+  ]
+}

.vscode/settings.json

@@ -16,5 +16,23 @@
     "test*.py"
   ],
   "python.testing.pytestEnabled": false,
-  "python.testing.unittestEnabled": true
+  "python.testing.unittestEnabled": true,
+  "go.useLanguageServer": true,
+  "go.toolsManagement.autoUpdate": true,
+  "go.lintTool": "golangci-lint",
+  "go.lintFlags": [
+    "--config=${workspaceFolder}/apps/node-disk-janitor/.golangci.yml"
+  ],
+  "gopls": {
+    "formatting.gofumpt": true,
+    "ui.semanticTokens": true,
+    "staticcheck": true
+  },
+  "[go]": {
+    "editor.defaultFormatter": "golang.Go",
+    "editor.formatOnSave": true,
+    "editor.codeActionsOnSave": {
+      "source.organizeImports": "explicit"
+    }
+  }
 }

Makefile

@@ -11,15 +11,17 @@ SSH_HOST ?= 76.13.108.14
 SSH_PORT ?= 22
 REMOTE_K3S_CMD ?= k3s ctr images import -
 SSH ?= ssh -p $(SSH_PORT) $(SSH_USER)@$(SSH_HOST)
+GOLANGCI_LINT ?= $(shell go env GOPATH)/bin/golangci-lint
 
-.PHONY: help lint deploy status e2e undeploy build-images import-images restart-apps fix-images logs-user logs-product logs-order logs-all logs-since import-images-remote deploy-remote fix-images-remote neon-plan neon-apply neon-destroy k3s-spot-plan k3s-spot-apply k3s-spot-destroy db-format db-validate db-generate db-migrate-status db-migrate-all concurrency-smoke concurrency-idempotency-lite concurrency-hotspot-100tps concurrency-baseline concurrency-stress100 concurrency-stress200 concurrency-hotspot require-tf-remote-state
+.PHONY: help lint lint-go deploy status e2e undeploy build-images import-images restart-apps fix-images logs-user logs-product logs-order logs-all logs-since import-images-remote deploy-remote fix-images-remote neon-plan neon-apply neon-destroy k3s-spot-plan k3s-spot-apply k3s-spot-destroy db-format db-validate db-generate db-migrate-status db-migrate-all concurrency-smoke concurrency-idempotency-lite concurrency-hotspot-100tps concurrency-baseline concurrency-stress100 concurrency-stress200 concurrency-hotspot require-tf-remote-state
 
 TAIL ?= 200
 SINCE ?= 10m
 
 help:
 >echo "Targets:"
 >echo "  make lint      # Run repo lint and shared pylint checks"
+>echo "  make lint-go   # Run golangci-lint for node-disk-janitor"
 >echo "  make deploy    # Deploy chart to local k3s"
 >echo "  make status    # Show pods and services"
 >echo "  make e2e       # Run E2E smoke test"
@@ -58,6 +60,9 @@ help:
 lint:
 >cd application/flashsale && uv run pre-commit run --all-files
 
+lint-go:
+>cd apps/node-disk-janitor && $(GOLANGCI_LINT) run --config .golangci.yml ./...
+
 concurrency-smoke concurrency-idempotency-lite concurrency-hotspot-100tps concurrency-baseline concurrency-stress100 concurrency-stress200 concurrency-hotspot:
 >$(MAKE) -C application/flashsale $@
 

apps/node-disk-janitor/.golangci.yml

@@ -0,0 +1,13 @@
+version: "2"
+
+run:
+  timeout: 3m
+  tests: true
+
+linters:
+  enable:
+    - errcheck
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused

apps/node-disk-janitor/predicates.go

@@ -19,7 +19,7 @@ func isTerminatedPod(pod corev1.Pod, cutoff time.Time) bool {
 		return false
 	}
 
-	if pod.Status.StartTime != nil && pod.Status.StartTime.Time.After(cutoff) {
+	if pod.Status.StartTime != nil && pod.Status.StartTime.After(cutoff) {
 		return false
 	}
 
@@ -65,7 +65,7 @@ func isNamespaceCleanupCandidate(namespace corev1.Namespace, cutoff time.Time, p
 	if namespace.DeletionTimestamp != nil || namespace.Status.Phase != corev1.NamespaceActive {
 		return false
 	}
-	if namespace.CreationTimestamp.Time.After(cutoff) {
+	if namespace.CreationTimestamp.After(cutoff) {
 		return false
 	}
 	return !slices.Contains(protected, namespace.Name)