Extended password quality checks #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like this small program (and most of all because it is so small but enough for most purposes).
However I considered that password quality check would be a handy feature. I know that MS Active Directory has built-in quality checks (except dictionary) but this is not the case for many other existing LDAP directories. I saw that there were already attempts to introduce quality check functionality, but the PR was declined (couldn't see why).
Tried to make password quality checks more configurable. You can enable different checks through config file
settings.ini, including mixed-case, digit, special character and dictionary checks. Dictionary is just a plain-text list of bad password patterns.Please let me know if this PR must be refined in some way. Thanks in advance!