Skip to content

Two ADRs still quote the retired WARNING: skipping run … sentence the binary no longer prints #228

Description

@jitokim

Address: docs/adr/0015-an-abandoned-run-is-derived-from-the-lock-not-repaired-into-the-feed.md:479, docs/adr/0023-a-run-has-one-status-and-planning-is-one-of-its-values.md:386

  • docs/adr/0015-an-abandoned-run-is-derived-from-the-lock-not-repaired-into-the-feed.md:479 — "lapses, and the directory becomes WARNING: skipping run … — it **vanishes"
  • docs/adr/0023-a-run-has-one-status-and-planning-is-one-of-its-values.md:386 — "which runs list reports through WARNING: skipping run … and the dashboard"

runs list stopped printing WARNING: skipping run %q: %v on this branch; the per-run sentence is now runstatus.UnreadableWARNING: run %q could not be read in full (%s): %v. Two ADRs still quote the retired string verbatim, in present tense, as if it were live output. A reader following ADR 0015 §4 or ADR 0023 §2.4 to reproduce the described behaviour will grep for a string that no longer exists in the binary.

The branch already treated this class of prose as needing an update — cmd/oh-my-graph/main.go:715 was rewritten in the same series to drop the quote — so stopping at the ADRs is a knowingly skipped surface, not an oversight of kind.

The fix is to re-quote both sites in the current sentence, or mark them explicitly as the wording of the day the ADR was written. Note that CHANGELOG.md:1311 also quotes it, but that entry sits under ## [v0.7.0] and is describing past behaviour, which is what a changelog is for — leave it alone.

Status: substantiated — both lines read directly; the repo-wide search for the string returns exactly these two plus the historical changelog entry and internal/runstatus/skipped.go:168, which quotes it on purpose as the sentence it replaces.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions