Reduce excessive logging (#1213)

* fix: Do not override log level for brewery rooms.

* Remove topology strategy log, too verbose.

* log: Move some logs from INFO to DEBUG.

Author: bgrozev

jicofo-common/src/main/kotlin/org/jitsi/jicofo/xmpp/XmppProvider.kt

@@ -258,7 +258,7 @@ class XmppProvider(val config: XmppConnectionConfig, parentLogger: Logger) {
     }
 
     @Throws(RoomExistsException::class)
-    fun createRoom(name: EntityBareJid): ChatRoom = muc.createChatRoom(name)
+    fun createRoom(name: EntityBareJid): ChatRoom = muc.createChatRoom(name, null)
     fun findOrCreateRoom(name: EntityBareJid, logLevel: Level): ChatRoom = muc.findOrCreateRoom(name, logLevel)
 
     fun discoverFeatures(jid: EntityFullJid): Set<Features> {
@@ -363,7 +363,7 @@ private class Muc(val xmppProvider: XmppProvider) {
     private val rooms: MutableMap<EntityBareJid, ChatRoomImpl> = HashMap()
 
     @Throws(RoomExistsException::class)
-    fun createChatRoom(roomJid: EntityBareJid, logLevel: Level = Level.ALL): ChatRoom {
+    fun createChatRoom(roomJid: EntityBareJid, logLevel: Level? = Level.ALL): ChatRoom {
         synchronized(rooms) {
             if (rooms.containsKey(roomJid)) {
                 throw RoomExistsException("Room '$roomJid' exists")

jicofo-common/src/main/kotlin/org/jitsi/jicofo/xmpp/jingle/JingleSession.kt

@@ -156,7 +156,7 @@ class JingleSession(
         /** Whether to send a session-terminate IQ, or only terminate the session locally. */
         sendIq: Boolean
     ) {
-        logger.info("Terminating session with $remoteJid, reason=$reason, sendIq=$sendIq")
+        logger.debug("Terminating session with $remoteJid, reason=$reason, sendIq=$sendIq")
         val oldState = state
         state = State.ENDED
 

jicofo-common/src/main/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoomImpl.kt

@@ -68,12 +68,12 @@ import java.util.logging.Level
 class ChatRoomImpl(
     override val xmppProvider: XmppProvider,
     override val roomJid: EntityBareJid,
-    logLevel: Level,
+    logLevel: Level?,
     /** Callback to call when the room is left. */
     private val leaveCallback: (ChatRoomImpl) -> Unit
 ) : ChatRoom, PresenceListener {
     private val logger = createLogger().apply {
-        level = logLevel
+        logLevel?.let { level = it }
         addContext("room", roomJid.toString())
     }
 

jicofo-selector/src/main/kotlin/org/jitsi/jicofo/bridge/BridgeSelectionStrategy.kt

@@ -47,7 +47,7 @@ abstract class BridgeSelectionStrategy {
             if (bridge != null) {
                 logger.info(
                     "Selected initial bridge $bridge with reported stress=${bridge.lastReportedStressLevel} " +
-                        "for participantProperties=$participantProperties using strategy ${this.javaClass.simpleName}"
+                        "for participantProperties=$participantProperties"
                 )
             } else {
                 logger.warn(

jicofo-selector/src/main/kotlin/org/jitsi/jicofo/bridge/colibri/ColibriV2SessionManager.kt

@@ -22,7 +22,7 @@ import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
 import org.jitsi.jicofo.OctoConfig
 import org.jitsi.jicofo.TaskPools
 import org.jitsi.jicofo.bridge.Bridge
-import org.jitsi.jicofo.bridge.BridgeConfig
+import org.jitsi.jicofo.bridge.BridgeConfig.Companion.config
 import org.jitsi.jicofo.bridge.BridgeSelector
 import org.jitsi.jicofo.bridge.Cascade
 import org.jitsi.jicofo.bridge.CascadeRepair
@@ -76,10 +76,6 @@ class ColibriV2SessionManager(
     override fun addListener(listener: ColibriSessionManager.Listener) = eventEmitter.addHandler(listener)
     override fun removeListener(listener: ColibriSessionManager.Listener) = eventEmitter.removeHandler(listener)
 
-    private val topologySelectionStrategy = BridgeConfig.config.topologyStrategy.also {
-        logger.info("Using ${it.javaClass.name}")
-    }
-
     /**
      * The colibri2 sessions that are currently active, mapped by the relayId of the [Bridge] that they use.
      */
@@ -124,14 +120,14 @@ class ColibriV2SessionManager(
         logger.debug { "Asked to remove $participantId" }
 
         participants[participantId]?.let {
-            logger.info("Removing ${it.id}")
+            logger.debug("Removing ${it.id}")
             removeParticipantInfosBySession(mapOf(it.session to singletonList(it)))
         } ?: logger.warn("Can not remove $participantId, no participantInfo")
         Unit
     }
 
     private fun repairMesh(cascade: ColibriV2SessionManager, disconnectedMeshes: Set<Set<Colibri2Session>>) =
-        topologySelectionStrategy.repairMesh(cascade, disconnectedMeshes)
+        config.topologyStrategy.repairMesh(cascade, disconnectedMeshes)
 
     private fun removeSession(session: Colibri2Session): Set<ParticipantInfo> {
         val participants = getSessionParticipants(session)
@@ -327,7 +323,7 @@ class ColibriV2SessionManager(
                 created = it.second
             }
             logger.info(
-                "Selected ${bridge.jid.resourceOrNull} for $${participant.id} " +
+                "Selected ${bridge.jid.resourceOrNull} for ${participant.id} " +
                     "(visitor=${participant.visitor}, session exists: ${!created})"
             )
             if (visitor != session.visitor) {
@@ -341,7 +337,7 @@ class ColibriV2SessionManager(
             stanzaCollector = session.sendAllocationRequest(participantInfo)
             add(participantInfo)
             if (created) {
-                val topologySelectionResult = topologySelectionStrategy.connectNode(
+                val topologySelectionResult = config.topologyStrategy.connectNode(
                     this,
                     session
                 )
@@ -560,7 +556,7 @@ class ColibriV2SessionManager(
         initialLastN: InitialLastN?,
         suppressLocalBridgeUpdate: Boolean
     ) = synchronized(syncRoot) {
-        logger.info("Updating $participantId with transport=$transport, sources=$sources")
+        logger.debug("Updating $participantId with transport=$transport, sources=$sources")
 
         val participantInfo = participants[participantId]
             ?: run {