use compareTo when comparing Jids (#339)

bbaldino · web-flow · commit 1788f06318f4 · 2019-01-24T12:43:00.000-08:00
the previous code was causing an issue where we'd compare the same JID
content (but different references) and Jicofo thought they weren't the
same.
diff --git a/src/main/java/org/jitsi/jicofo/recording/jibri/JibriSession.java b/src/main/java/org/jitsi/jicofo/recording/jibri/JibriSession.java
@@ -490,10 +490,10 @@ private void handleJibriStatusUpdate(
         jibriStatus = newStatus;
         logger.info("Got Jibri status update: Jibri " + jibriJid + " has status " + newStatus +
                 " and failure reason " + failureReason);
-        if (jibriJid != currentJibriJid)
+        if (jibriJid.compareTo(currentJibriJid) != 0)
         {
             logger.info("This status update is from " + jibriJid +
-                    "but the current Jibri is " + currentJibriJid + ", ignoring");
+                    " but the current Jibri is " + currentJibriJid + ", ignoring");
             return;
         }
         // First: if we're no longer pending (regardless of the Jibri's new state), make sure we stop

Original file line number	Diff line number	Diff line change
`@@ -490,10 +490,10 @@ private void handleJibriStatusUpdate(`
`490`	`490`	`jibriStatus = newStatus;`
`491`	`491`	`logger.info("Got Jibri status update: Jibri " + jibriJid + " has status " + newStatus +`
`492`	`492`	`" and failure reason " + failureReason);`
`493`		`- if (jibriJid != currentJibriJid)`
	`493`	`+ if (jibriJid.compareTo(currentJibriJid) != 0)`
`494`	`494`	`{`
`495`	`495`	`logger.info("This status update is from " + jibriJid +`
`496`		`- "but the current Jibri is " + currentJibriJid + ", ignoring");`
	`496`	`+ " but the current Jibri is " + currentJibriJid + ", ignoring");`
`497`	`497`	`return;`
`498`	`498`	`}`
`499`	`499`	`// First: if we're no longer pending (regardless of the Jibri's new state), make sure we stop`