Added separate exception for the case when it should be conference expiration and then re-request allocation for endpoint when allocation is failed with error of already existed conference which can happen after jicofo restart. Moved the logging level to WARN for such case. (#1005)

Author: mykhailo-ua

jicofo-selector/src/main/kotlin/org/jitsi/jicofo/bridge/colibri/ColibriV2SessionManager.kt

@@ -368,7 +368,12 @@ class ColibriV2SessionManager(
             try {
                 return handleResponse(response, session, created, participantInfo)
             } catch (e: Exception) {
-                logger.error("Failed to allocate a colibri2 endpoint for ${participantInfo.id}: ${e.message}")
+                if (e is ConferenceAlreadyExistsException) {
+                    logger.warn("Failed to allocate a colibri2 endpoint for ${participantInfo.id}: ${e.message}")
+                } else {
+                    logger.error("Failed to allocate a colibri2 endpoint for ${participantInfo.id}: ${e.message}")
+                }
+
                 if (e is ColibriAllocationFailedException && e.removeBridge) {
                     // Add participantInfo just in case it wasn't there already (the set will take care of dups).
                     val removedParticipants = removeSession(session) + participantInfo
@@ -443,6 +448,10 @@ class ColibriV2SessionManager(
                             "XMPP error: ${response.error?.toXML()}",
                             true
                         )
+                    } else if (reason == Colibri2Error.Reason.CONFERENCE_ALREADY_EXISTS) {
+                        // The conference on the bridge already exists. The state between jicofo and the bridge
+                        // is out of sync.
+                        throw ConferenceAlreadyExistsException("Conference already exists error", true)
                     } else {
                         // An error coming from the bridge. The state between jicofo and the bridge must be out of sync.
                         // It's not clear how to handle this. Ideally we should expire the conference and retry, but

jicofo-selector/src/main/kotlin/org/jitsi/jicofo/bridge/colibri/Exceptions.kt

@@ -18,7 +18,12 @@ package org.jitsi.jicofo.bridge.colibri
 /** Bridge selection failed, i.e. there were no bridges available. */
 class BridgeSelectionFailedException : Exception("Bridge selection failed")
 
-class ColibriAllocationFailedException(
+open class ColibriAllocationFailedException(
     message: String = "",
     val removeBridge: Boolean = false
 ) : Exception(message)
+
+class ConferenceAlreadyExistsException(
+    message: String,
+    removeBridge: Boolean
+) : ColibriAllocationFailedException(message, removeBridge)

jicofo/src/main/java/org/jitsi/jicofo/conference/ParticipantInviteRunnable.java

@@ -214,6 +214,12 @@ private void doRun()
             cancel();
             return;
         }
+        catch (ConferenceAlreadyExistsException e)
+        {
+            logger.warn("Can not allocate colibri channels, conference already exists.");
+            cancel();
+            return;
+        }
         catch (ColibriAllocationFailedException e)
         {
             logger.error("Failed to allocate colibri channels", e);