Skip to content

Commit 10796a6

Browse files
committed
chore(redux) don't use Symbol for action types
It makes debugging harder and has no benefit.
1 parent b19c968 commit 10796a6

File tree

5 files changed

+15
-16
lines changed

5 files changed

+15
-16
lines changed

app/features/conference/actionTypes.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* conference
77
* }
88
*/
9-
export const CONFERENCE_JOINED = Symbol('CONFERENCE_JOINED');
9+
export const CONFERENCE_JOINED = 'CONFERENCE_JOINED';
1010

1111
/**
1212
* The type of (redux) action that is dispatched when conference ends.
@@ -15,4 +15,5 @@ export const CONFERENCE_JOINED = Symbol('CONFERENCE_JOINED');
1515
* type: CONFERENCE_ENDED,
1616
* conference
1717
* }
18-
*/export const CONFERENCE_ENDED = Symbol('CONFERENCE_ENDED');
18+
*/
19+
export const CONFERENCE_ENDED = 'CONFERENCE_ENDED';

app/features/navbar/actionTypes.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* drawerComponent: React.ComponentType<*>
77
* }
88
*/
9-
export const OPEN_DRAWER = Symbol('OPEN_DRAWER');
9+
export const OPEN_DRAWER = 'OPEN_DRAWER';
1010

1111
/**
1212
* The type of (redux) action that closes all Drawer.
@@ -15,4 +15,4 @@ export const OPEN_DRAWER = Symbol('OPEN_DRAWER');
1515
* type: CLOSE_DRAWER
1616
* }
1717
*/
18-
export const CLOSE_DRAWER = Symbol('CLOSE_DRAWER');
18+
export const CLOSE_DRAWER = 'CLOSE_DRAWER';

app/features/onboarding/actionTypes.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* type: CONTINUE_ONBOARDING
77
* }
88
*/
9-
export const CONTINUE_ONBOARDING = Symbol('CONTINUE_ONBOARDING');
9+
export const CONTINUE_ONBOARDING = 'CONTINUE_ONBOARDING';
1010

1111
/**
1212
* The type of (redux) action that sets active onboarding.
@@ -17,7 +17,7 @@ export const CONTINUE_ONBOARDING = Symbol('CONTINUE_ONBOARDING');
1717
* section
1818
* }
1919
*/
20-
export const SET_ACTIVE_ONBOARDING = Symbol('SET_ACTIVE_ONBOARDING');
20+
export const SET_ACTIVE_ONBOARDING = 'SET_ACTIVE_ONBOARDING';
2121

2222
/**
2323
* The type of (redux) action that starts Onboarding.
@@ -27,7 +27,7 @@ export const SET_ACTIVE_ONBOARDING = Symbol('SET_ACTIVE_ONBOARDING');
2727
* section
2828
* }
2929
*/
30-
export const START_ONBOARDING = Symbol('START_ONBOARDING');
30+
export const START_ONBOARDING = 'START_ONBOARDING';
3131

3232
/**
3333
* The type of (redux) action that skips all onboarding.
@@ -36,4 +36,4 @@ export const START_ONBOARDING = Symbol('START_ONBOARDING');
3636
* type: SKIP_ONBOARDING
3737
* }
3838
*/
39-
export const SKIP_ONBOARDING = Symbol('SKIP_ONBOARDING');
39+
export const SKIP_ONBOARDING = 'SKIP_ONBOARDING';
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
/**
2-
* The type of (redux) action that is dispatched when a conference is removed from the recents list.
2+
* The type of (redux) action that is dispatched when a conference is removed from the recent list.
33
*
44
* @type {
55
* type: CONFERENCE_REMOVED,
66
* conference
77
* }
88
*/
9-
export const CONFERENCE_REMOVED = Symbol('CONFERENCE_REMOVED');
10-
9+
export const CONFERENCE_REMOVED = 'CONFERENCE_REMOVED';

app/features/settings/actionTypes.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
* alwaysOnTopWindowEnabled
77
* }
88
*/
9-
export const SET_ALWAYS_ON_TOP_WINDOW_ENABLED
10-
= Symbol('SET_ALWAYS_ON_TOP_WINDOW_ENABLED');
9+
export const SET_ALWAYS_ON_TOP_WINDOW_ENABLED = 'SET_ALWAYS_ON_TOP_WINDOW_ENABLED';
1110

1211
/**
1312
* The type of (redux) action that sets disable AGC.
@@ -17,7 +16,7 @@ export const SET_ALWAYS_ON_TOP_WINDOW_ENABLED
1716
* disableAGC
1817
* }
1918
*/
20-
export const SET_DISABLE_AGC = Symbol('SET_DISABLE_AGC');
19+
export const SET_DISABLE_AGC = 'SET_DISABLE_AGC';
2120

2221
/**
2322
* The type of (redux) action that sets the Server URL.
@@ -27,7 +26,7 @@ export const SET_DISABLE_AGC = Symbol('SET_DISABLE_AGC');
2726
* serverURL
2827
* }
2928
*/
30-
export const SET_SERVER_URL = Symbol('SET_SERVER_URL');
29+
export const SET_SERVER_URL = 'SET_SERVER_URL';
3130

3231
/**
3332
* The type of (redux) action that sets the Server Timeout.
@@ -37,4 +36,4 @@ export const SET_SERVER_URL = Symbol('SET_SERVER_URL');
3736
* serverTimeout
3837
* }
3938
*/
40-
export const SET_SERVER_TIMEOUT = Symbol('SET_SERVER_TIMEOUT');
39+
export const SET_SERVER_TIMEOUT = 'SET_SERVER_TIMEOUT';

0 commit comments

Comments
 (0)