fix the safeSubtract

manzil-infinity180 · manzil-infinity180 · commit 05a49133fcf1 · 2025-02-18T02:16:12.000+05:30
diff --git a/modules/util/MathUtil.ts b/modules/util/MathUtil.ts
@@ -105,5 +105,7 @@ export class RunningAverage {
  * @returns {number} - x - y or 0 if x or is not a number.
  */
 export function safeSubtract(x:unknown, y:unknown):number {
-    return typeof x === 'number' && typeof y === 'number' ? x - y : 0;
+    const numX = Number(x);
+    const numY = Number(y);
+    return !Number.isNaN(x) && !Number.isNaN(y) ? numX - numY : 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -105,5 +105,7 @@ export class RunningAverage {`
`105`	`105`	`* @returns {number} - x - y or 0 if x or is not a number.`
`106`	`106`	`*/`
`107`	`107`	`export function safeSubtract(x:unknown, y:unknown):number {`
`108`		`- return typeof x === 'number' && typeof y === 'number' ? x - y : 0;`
	`108`	`+ const numX = Number(x);`
	`109`	`+ const numY = Number(y);`
	`110`	`+ return !Number.isNaN(x) && !Number.isNaN(y) ? numX - numY : 0;`
`109`	`111`	`}`