Skip to content

Commit 798354b

Browse files
committed
fix types
1 parent 3dc7f21 commit 798354b

File tree

4 files changed

+10
-18
lines changed

4 files changed

+10
-18
lines changed

modules/RTC/RTC.ts

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ import BridgeChannel from './BridgeChannel';
1818
import JitsiLocalTrack, { IStreamEffect, ITrackConstraints } from './JitsiLocalTrack';
1919
import JitsiRemoteTrack from './JitsiRemoteTrack';
2020
import RTCUtils from './RTCUtils';
21-
import TraceablePeerConnection, { ITPCOptions } from './TraceablePeerConnection';
21+
import TraceablePeerConnection, { IAudioQuality, ITPCOptions, IVideoQuality } from './TraceablePeerConnection';
22+
import { IFrameRateConfig } from './ScreenObtainer';
2223

2324
// Extend RTCConfiguration to include the encodedInsertableStreams property
2425
interface IExtendedRTCConfiguration extends RTCConfiguration {
@@ -107,13 +108,8 @@ function _createLocalTracks(mediaStreamMetaData: IMediaStreamMetaData[] = []): J
107108
* Interface for RTC options
108109
*/
109110
export interface IRTCOptions {
110-
audioQuality?: {
111-
stereo?: boolean;
112-
};
113-
desktopSharingFrameRate?: {
114-
max?: number;
115-
min?: number;
116-
};
111+
audioQuality?: IAudioQuality;
112+
desktopSharingFrameRate?: IFrameRateConfig;
117113
disableAEC?: boolean;
118114
disableAGC?: boolean;
119115
disableAP?: boolean;
@@ -123,11 +119,7 @@ export interface IRTCOptions {
123119
audio?: MediaTrackConstraints | boolean;
124120
video?: MediaTrackConstraints | boolean;
125121
};
126-
videoQuality?: {
127-
disabledCodec?: string;
128-
enableAdaptiveMode?: boolean;
129-
maxbitratesvideo?: Record<string, any>;
130-
};
122+
videoQuality?: IVideoQuality;
131123
}
132124

133125
/**

modules/RTC/ScreenObtainer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const logger = getLogger('modules/RTC/ScreenObtainer');
99
/**
1010
* Interface for desktop sharing frame rate configuration.
1111
*/
12-
interface IFrameRateConfig {
12+
export interface IFrameRateConfig {
1313
max?: number;
1414
min?: number;
1515
}

modules/RTC/TraceablePeerConnection.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ export interface IAudioQuality {
9090
}
9191

9292
export interface IVideoQuality {
93+
disabledCodec?: string;
94+
enableAdaptiveMode?: boolean;
9395
maxBitratesVideo?: Record<string, number>;
9496
preferredCodec?: CodecMimeType;
9597
}

modules/xmpp/JingleSessionPC.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { AnalyticsEvents } from '../../service/statistics/AnalyticsEvents';
1313
import { XMPPEvents } from '../../service/xmpp/XMPPEvents';
1414
import { XEP } from '../../service/xmpp/XMPPExtensioProtocols';
1515
import JitsiLocalTrack from '../RTC/JitsiLocalTrack';
16-
import { SS_DEFAULT_FRAME_RATE } from '../RTC/ScreenObtainer';
16+
import { IFrameRateConfig, SS_DEFAULT_FRAME_RATE } from '../RTC/ScreenObtainer';
1717
import TraceablePeerConnection, { IAudioQuality, ICodecSettings, IVideoQuality } from '../RTC/TraceablePeerConnection';
1818
import browser from '../browser';
1919
import FeatureFlags from '../flags/FeatureFlags';
@@ -121,9 +121,7 @@ interface IJingleSessionPCOptions {
121121
audioQuality?: IAudioQuality;
122122
channelLastN?: number;
123123
codecSettings?: ICodecSettings;
124-
desktopSharingFrameRate?: {
125-
max?: number;
126-
};
124+
desktopSharingFrameRate?: IFrameRateConfig;
127125
disableRtx?: boolean;
128126
disableSimulcast?: boolean;
129127
enableInsertableStreams?: boolean;

0 commit comments

Comments
 (0)