Merge branch 'master' into RTCStatsCollector

Author: jallamsetty1

JitsiConference.ts

@@ -1429,9 +1429,10 @@ export default class JitsiConference extends Listenable {
             }, {
                 reason,
                 reasonDescription,
-                sendSessionTerminate: this.room
+                sendSessionTerminate: Boolean(this.room
                     && this.getParticipantById(
                         Strophe.getResourceFromJid(this.p2pJingleSession.remoteJid))
+                )
             });
 
         this.p2pJingleSession = null;

modules/RTC/TraceablePeerConnection.ts

@@ -230,7 +230,7 @@ export default class TraceablePeerConnection {
          * media direction will be adjusted to 'inactive' in order to suspend
          * the transmission.
          * @type {boolean}
-         * @private
+         * @internal
          */
         this.audioTransferActive = !(options.startSilent === true);
 
@@ -266,7 +266,7 @@ export default class TraceablePeerConnection {
          * media direction will be adjusted to 'inactive' in order to suspend
          * the transmission.
          * @type {boolean}
-         * @private
+         * @internal
          */
         this.videoTransferActive = true;
 
@@ -1232,7 +1232,7 @@ export default class TraceablePeerConnection {
      * @return {string} one of the SDP direction constants ('sendrecv, 'recvonly' etc.)
      * which should be used when setting
      * local description on the peerconnection.
-     * @private
+     * @internal
      */
     getDesiredMediaDirection(mediaType: MediaType, isAddOperation = false): MediaDirection {
         return this.tpcUtils.getDesiredMediaDirection(mediaType, isAddOperation);
@@ -2047,7 +2047,7 @@ export default class TraceablePeerConnection {
      * @param {RTCSessionDescription} - The local description to be used.
      * @returns {Array}
      */
-    getConfiguredVideoCodecs(description: RTCSessionDescription): CodecMimeType[] {
+    getConfiguredVideoCodecs(description?: RTCSessionDescription): CodecMimeType[] {
         return this.tpcUtils.getConfiguredVideoCodecs(description?.sdp);
     }
 
@@ -2543,7 +2543,7 @@ export default class TraceablePeerConnection {
      * sender associated with the video source.
      * @returns {Promise} promise that will be resolved when the operation is successful and rejected otherwise.
      */
-    setSenderVideoConstraints(frameHeight: number, localVideoTrack: JitsiLocalTrack, preferredCodec: Optional<CodecMimeType>): Promise<void> {
+    setSenderVideoConstraints(frameHeight: number, localVideoTrack: JitsiLocalTrack, preferredCodec?: Optional<CodecMimeType>): Promise<void> {
         if (frameHeight < 0 || !isValidNumber(frameHeight)) {
             throw new Error(`Invalid frameHeight: ${frameHeight}`);
         }
@@ -2575,7 +2575,7 @@ export default class TraceablePeerConnection {
      * @returns {Promise} - A promise that is resolved when the change is succesful on all the senders, rejected
      * otherwise.
      */
-    setMediaTransferActive(enable: boolean, mediaType: Optional<MediaType>): Promise<void> {
+    setMediaTransferActive(enable: boolean, mediaType?: Optional<MediaType>): Promise<void> {
         logger.info(`${this} ${enable ? 'Resuming' : 'Suspending'} media transfer.`);
 
         const senders = this.peerconnection.getSenders()

modules/sdp/SDPUtil.js

@@ -257,7 +257,7 @@ const SDPUtil = {
      * @param {string} haystack - The SDP string to search.
      * @param {string} needle - The line prefix to find.
      * @param {string} sessionpart - The session part to search within.
-     * @returns {string|boolean} - The found line or false if not found.
+     * @returns {Optional<string>} - The found line or false if not found.
      */
     findLine(haystack, needle, sessionpart) {
         let lines = haystack.split('\r\n');
@@ -268,7 +268,7 @@ const SDPUtil = {
             }
         }
         if (!sessionpart) {
-            return false;
+            return undefined;
         }
 
         // search session part
@@ -279,7 +279,7 @@ const SDPUtil = {
             }
         }
 
-        return false;
+        return undefined;
     },
 
     /**