Skip to content

Commit ecd43c9

Browse files
committed
feat(ChatRoom) drop deprecated _addToPresence method
We mistakenly renamed it from addToPresence to _addToPresence, breaking Spot and Jibri in the process. Since the breakage is already there, and we have had a replacement for years, we'll switch to it on both applications.
1 parent 3fd46b5 commit ecd43c9

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

modules/xmpp/ChatRoom.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,6 @@ export default class ChatRoom extends Listenable {
384384
}
385385
}
386386

387-
388387
/**
389388
*
390389
* @param node
@@ -404,22 +403,6 @@ export default class ChatRoom extends Listenable {
404403
}
405404
}
406405

407-
408-
/**
409-
* Adds the key to the presence map, overriding any previous value.
410-
* This method is used by jibri.
411-
*
412-
* @param key The key to add or replace.
413-
* @param values The new values.
414-
* @returns {boolean|null} <tt>true</tt> if the operation succeeded or <tt>false</tt> when no add or replce was
415-
* performed as the value was already there.
416-
* @deprecated Use 'addOrReplaceInPresence' instead. TODO: remove it from here and jibri.
417-
*/
418-
private _addToPresence(key: string, values: any): Nullable<boolean> {
419-
return this.addOrReplaceInPresence(key, values);
420-
}
421-
422-
423406
/**
424407
* Clean any listeners or resources, executed on leaving.
425408
*/
@@ -437,7 +420,6 @@ export default class ChatRoom extends Listenable {
437420
this.inProgressEmitted = false;
438421
}
439422

440-
441423
/**
442424
* Joins the chat room.
443425
* @param {string} password - Password to unlock room on joining.

0 commit comments

Comments
 (0)