jive-persistence-mongo is not compatible with the API of the default file persistence, it only accepts objects as data

[naugtur]

Passing a string as data argument to the save method causes the implementation here to pass the string to collection.update which throws an error.

if jive-persistence-mongo wants to support storing multiple data types, it needs to wrap the incoming data in a simple object.
Otherwise, consistency should be provided to the users by making the simpler storages throw errors in the same cases.

[naugtur]

jive-persistence-mongo doesn't have any tests and I don't see how to run jive-sdk tests with mongo persistence.

The find function here has more capabilities than in file and memory persistence.

[rachoac]

Regarding tests:

1. start up mongodb server

2. run the tests:
   cd jive-persistence-mongo/test
   node run.js

   [2014-09-12 07:28:58.231] [INFO] jive-sdk - ******************
   [2014-09-12 07:28:58.234] [INFO] jive-sdk - MongoDB configured
   [2014-09-12 07:28:58.234] [INFO] jive-sdk - ******************
   [2014-09-12 07:29:00.519] [INFO] jive-sdk - ******************
   [2014-09-12 07:29:00.519] [INFO] jive-sdk - MongoDB configured
   [2014-09-12 07:29:00.520] [INFO] jive-sdk - ******************
   [2014-09-12 07:29:03.228] [INFO] jive-sdk - ******************
   [2014-09-12 07:29:03.229] [INFO] jive-sdk - MongoDB configured
   [2014-09-12 07:29:03.229] [INFO] jive-sdk - ******************
   [2014-09-12 07:29:05.343] [INFO] jive-sdk - ******************
   [2014-09-12 07:29:05.343] [INFO] jive-sdk - MongoDB configured
   [2014-09-12 07:29:05.343] [INFO] jive-sdk - ******************

   4 passing (10s)

[rachoac]

File persistence API docs state that it takes data object. The API of both want data.

    /**
     * Save the provided data in a named collection
     * @memberof filePersistence
     * @param {String} collectionID
     * @param {String} key
     * @param {Object} data
     * @returns {Promise} promise
     */
    save : function( collectionID, key, data) {
      ...

See also https://cdn.rawgit.com/jivesoftware/jive-sdk/master/docs/api/filePersistence.html

[naugtur]

Thanks. I don't know how I missed the tests :)

So the take away from this is that all persistence implementations should check if data argument is an object. They don't do that right now and the error thrown comes from mongojs

I'll make a pull request on monday with suggestions of error handling.