Experimental tab-completion adding spaces after directory paths

[BatmanAoD]

It appears that the experimental bash-completions, e.g. for jj restore, is adding a space after each tab-completion, even if the file path so far is a non-empty directory, i.e. there is potentially a more specific completion that the user wants. This is awkward, because it requires using backspace to finish typing the path, which is something I haven't seen other autocompleters do (for any tool that has file-path arguments).

I have not tested this in other shells.

[yuja]

yeah, it's annoying. afaik, it works on fish, but not on zsh (with my confugration.)

[Adda0]

Interesting that the completions work differently for each of us. The tab-completion for paths works as intended (that is, no space for non-empty folders) for me with the dynamic jj completions (versions 0.23, 0.24) for both Zsh and Bash.

[wjv]

I'll just add here what I said on Discord before realising there's an issue filed:

• The problem occurs for me on zsh 5.9 on macOS 15.2. I have not tested other configs.
• It occurred even on a clean copy of zsh started without config (zsh -f), so it's unlikely to be my config.
• It occurs in both emacs and vi modes.
• The problem does not occur if one uses "static" completions.

(I'm assuming the problem lies with clap rather than jj itself.)

[wjv]

See: clap-rs/clap#5587

[evmar]

How can I use "static" completions? I have a wholly unconfigured stock Mac zsh and jj.

[martinvonz]

See "Standard" here: https://jj-vcs.github.io/jj/latest/install-and-setup/#zsh

[tjarvstrand]

Is there any known workaround for this? I love jj but this is driving me nuts.

[wjv]

Only using "standard" (that is, non-dynamic) completions, I'm afraid.

[lowking]

Same as me.
Related issues:
zplug/zplug#602
#6660

[lowking]

I finally found the file and solved it. The answer has been written in the issue. I hope it will be helpful to you.

[wjv]

A note for people installing jj from Homebrew on macOS:

The brew recipe for jj automatically activates dynamic completion from a completion script installed as:

• /opt/homebrew/share/zsh/site-functions/_jj (on Apple Silicon Macs), or
• /usr/local/share/zsh/site-functions/_jj (on Intel Macs).

If you want to use static completions to avoid the extra space bug, you'll have to first delete this _jj every time you upgrade jj using Homebrew. (Or, of course, install jj using some other methodology.)

The dynamic completions for Homebrewed jj were added here: Homebrew/homebrew-core@cebd354