Why does jj st show that all files have been modified after jj git init --colocate an existing git repo?

[ninety7]

I am trying out jj for the first time with an existing git repository. After running the jj git init --colocate command, I see that all of my files report as being changed by jj st, although I can't see any actual changes reported by git status.

I ran jj diff and it looks like the files have been re-added?

Modified regular file .gitattributes:                                                                                                                                                                                                                                                                               
   1    1: ###############################################################################<0D>
   2    2: # Set default behavior to automatically normalize line endings.<0D>
   3    3: ###############################################################################<0D>
   4    4: * text=auto<0D>
   5    5: <0D>
   6    6: ###############################################################################<0D>
   7    7: # Set default behavior for command prompt diff.<0D>
   8    8: #<0D>
...

I was expecting jj st to not show any changes on the working copy as in git status, especially when it seems like it is just re-adding the files to the repository.

Is there something I might be ignoring, or is this how jj is supposed to work after colocating?

OS: Windows 11

[PhilipMetzger]

this is because jj doesn't have an equivalent to core.autocrlf yet, so the files contents are written with a unix linefeed to the underlying store.

[ninety7]

Is there a workaround solution to this? In the end, I want to avoid having a commit that just re-adds all files to the repository. If I change core.autocrlf to input and then jj abandon, jj st will still report that all files have been modified, plus, git status also reports all files have the line separator changed to LF. What's the suggested course of action in this case?

[PhilipMetzger]

I think @jennings has a good workaround for this by creating a top-level editorconfig with the correct LF options, but he should expand on this

[jennings]

jj abandon on the change that is converting everything to CRLF should convert all the files in the working copy to LF line endings, so then jj status should not show them as modified anymore. If that’s not happening, something else is going on.

You can then use git add --renormalize -A to fix git’s index after setting core.autocrlf to input.

[ninety7]

Thank you! the git add --renormalize -A was the missing piece! When is a definite fix expected to land for windows users? If not, I can submit a PR to update the Working on Windows page

[PhilipMetzger]

When is a definite fix expected to land for windows users?

the LF issue is non-trivial and has been discussed multiple times over the years with no easy fix yet. cc @gulbanana who had some ideas around it.

If not, I can submit a PR to update the Working on Windows page

That's always appreciated so do your thing.

[cenviity]

Related issue: #53