Remove parameters from send()

[PetrHudik]

I don't underestant why in send() method are two parameters. You don't use it anyway.

In my opintion, it will be better just without or with default value:

    /**
     * Sends response to output.
     * @return void
     */
    public function send(IRequest $httpRequest = NULL, IResponse $httpResponse = NULL) {
        // ...
    }

Then you can use it anywhare without unnecessary dependencies:

        $template = $this->createTemplate()->setFile( /* ... */ );
        $template->data = $data;
        $pdf = new PdfResponse($template);
        $pdf->outputName = $fileName; 
        $pdf->outputDestination = PdfResponse::OUTPUT_FILE;
        $pdf->send();

Maybe I just missing something important.

[jkuchar]

;-) This the answer: http://api.nette.org/2.0.18/Nette.Application.IResponse.html

But yes, it looks like good ideat to extract content of that method to another one (e.g. sendResponse()). What do you think?

[PetrHudik]

Thanks for quik reply.

Yes, extracting to another method works for me.

[jkuchar]

Could you please send PR? :)

[PetrHudik]

Sure, I'll do my best. But it will be done next week.

[PetrHudik]

So, I've worked on this and here is result:

1. In my opinion, the best solution is just add default values to function. I think you CAN have default values in function implementing interface. So, here is my solution:

PetrHudik@83e83fe

2. Here's suggested solution - extracting content to another method:

PetrHudik@d3ace7b

3. While i was working with saving files, function saveFile() can be handy:

PetrHudik@3a41981

What do you think? Witch solution is best for you?