Fix VPA tests since VPA mutex can't be copied

Since I added a mutex to the VPA model, the checkpoint text can no
longer copy it by value and has to use references. This just updates the
checkpoint writer test to account for this.

Signed-off-by: John Kyros <[email protected]>

Author: jkyros

vertical-pod-autoscaler/pkg/recommender/checkpoint/checkpoint_writer_test.go

@@ -108,15 +108,15 @@ func TestMergeContainerStateForCheckpointDropsRecentMemoryPeak(t *testing.T) {
 func TestIsFetchingHistory(t *testing.T) {
 
 	testCases := []struct {
-		vpa               model.Vpa
+		vpa               *model.Vpa
 		isFetchingHistory bool
 	}{
 		{
-			vpa:               model.Vpa{},
+			vpa:               &model.Vpa{},
 			isFetchingHistory: false,
 		},
 		{
-			vpa: model.Vpa{
+			vpa: &model.Vpa{
 				PodSelector: nil,
 				Conditions: map[vpa_types.VerticalPodAutoscalerConditionType]vpa_types.VerticalPodAutoscalerCondition{
 					vpa_types.FetchingHistory: {
@@ -128,7 +128,7 @@ func TestIsFetchingHistory(t *testing.T) {
 			isFetchingHistory: false,
 		},
 		{
-			vpa: model.Vpa{
+			vpa: &model.Vpa{
 				PodSelector: nil,
 				Conditions: map[vpa_types.VerticalPodAutoscalerConditionType]vpa_types.VerticalPodAutoscalerCondition{
 					vpa_types.FetchingHistory: {
@@ -142,7 +142,7 @@ func TestIsFetchingHistory(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		assert.Equalf(t, tc.isFetchingHistory, isFetchingHistory(&tc.vpa), "%+v should have %v as isFetchingHistoryResult", tc.vpa, tc.isFetchingHistory)
+		assert.Equalf(t, tc.isFetchingHistory, isFetchingHistory(tc.vpa), "%+v should have %v as isFetchingHistoryResult", tc.vpa, tc.isFetchingHistory)
 	}
 }