Skip to content

Viewport issue on slider #567

@zborkala

Description

@zborkala
before_changes.1.mp4

Replacing the following lines in isElementVisible() function solves the problem of viewport issue on slider.

function isElementVisible(element) {
    ...
    var elementRect = element.node.getBoundingClientRect();
    var geoBounds = element.geometry.bounds;
    var highestBound = {
        left: Math.min(elementRect.left, geoBounds.left),
        right: Math.max(elementRect.right, geoBounds.right),
        top: Math.max(elementRect.top, geoBounds.top),
        bottom: Math.max(elementRect.bottom, geoBounds.bottom),
    }


    var elementBounds = {
        top: highestBound.top + element.geometry.height * viewFactor,
        right: highestBound.right - element.geometry.width * viewFactor,
        bottom: highestBound.bottom - element.geometry.height * viewFactor,
        left: highestBound.left + element.geometry.width * viewFactor
    };
    ....
}
after_changes.1.mp4

But, you have to call ScrollReveal().delegate() function on the corresponding event listeners. Because ScrollReveal.js only works on scroll and resize event.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions